Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bug in slice operator with default inputs #2463

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: Bug in slice operator with default inputs #2463

merged 2 commits into from
Nov 27, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Slice operator schema allows optional inputs for specified dimensions and allows not specifying certain inputs at all
  • Fix issue where the converter did not reflect these Torch behaviors
  • Fix issue where bounds past the end of the array were not allowed (as they are in Python, ONNX, Torch)
  • Add regression tests to catch such errors

Slice Schema

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Bug in slice operator with default inputs
7ed104c 
- Slice operator schema allows optional inputs for specified dimensions
and allows not specifying certain inputs at all
- Fix issue where the converter did not reflect these Torch behaviors
- Fix issue where bounds past the end of the array were not allowed (as
they are in Python, ONNX, Torch)
- Add regression tests to catch such errors
@gs-olive gs-olive requested review from zewenli98 and apbose November 13, 2023 23:50
@gs-olive gs-olive self-assigned this Nov 13, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Nov 13, 2023
@github-actions github-actions bot requested a review from peri044 November 13, 2023 23:50
@gs-olive gs-olive requested a review from borisfom November 13, 2023 23:52
zewenli98
zewenli98 reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, just a few suggestions as mentioned in the comments.

tests/py/dynamo/conversion/test_slice_aten.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
@gs-olive gs-olive requested a review from zewenli98 November 14, 2023 23:52
zewenli98
zewenli98 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gs-olive gs-olive merged commit 7323c86 into pytorch:main Nov 27, 2023
17 of 19 checks passed
@gs-olive gs-olive deleted the slice_op_fix branch November 27, 2023 18:30
gs-olive added a commit that referenced this pull request Nov 29, 2023
@gs-olive
fix: Bug in slice operator with default inputs (#2463)
b5dc751
@gs-olive gs-olive mentioned this pull request Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zewenli98 zewenli98 zewenli98 approved these changes

@apbose apbose Awaiting requested review from apbose

@peri044 peri044 Awaiting requested review from peri044

@borisfom borisfom Awaiting requested review from borisfom

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @zewenli98 @facebook-github-bot