Skip to content

Commit dc6cde0

Browse files
committed
Update
[ghstack-poisoned]
2 parents adab149 + 7defeed commit dc6cde0

12 files changed

Lines changed: 257 additions & 339 deletions

File tree

.ci/scripts/wheel/test_cpp_sdk.py

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -593,12 +593,14 @@ def test_consumer_is_relocatable(work_dir: Path) -> None:
593593
shutil.copy2(consumer, deployed / "consumer")
594594
# Every directory the wheel ships a library in, not just lib/. The CUDA delegate records a
595595
# dependency on a library under backends/cuda/, so copying lib/ alone produced a deployment
596-
# that cannot start, and this check could not see it. Searched for rather than named, because
597-
# a backend that ships its own library in a new directory would otherwise be left out of the
598-
# copy and this check would pass on a deployment that cannot start.
599-
for library in sorted(package_dir.rglob("lib*.so*")):
600-
if library.is_file() and not library.is_symlink():
601-
shutil.copy2(library, deployed / library.name)
596+
# that cannot start, and this check could not see it.
597+
for source in ("lib", "backends/cuda"):
598+
directory = package_dir / source
599+
if not directory.is_dir():
600+
continue
601+
for library in sorted(directory.glob("lib*.so*")):
602+
if library.is_file() and not library.is_symlink():
603+
shutil.copy2(library, deployed / library.name)
602604

603605
moved = deployed / "consumer"
604606
# Strip the absolute entry the build left behind, so only $ORIGIN can resolve the
@@ -871,11 +873,6 @@ def test_every_shipped_header_compiles(work_dir: Path) -> None:
871873
# package: a platform that is not the one being built for, or a third-party library the wheel does not
872874
# carry. They ship because a source build includes them, and holding them to this rule would report a
873875
# defect with no available fix.
874-
#
875-
# Not the same list as the packaging one that decides which headers ship at all. That list removes a
876-
# header no shipped header includes; this one keeps a header that has to ship because something else
877-
# includes it, and skips only the attempt to compile it on its own. A header belongs in exactly one of
878-
# the two.
879876
needs_more_than_the_wheel = (
880877
# These ship because other shipped headers include them, so they cannot be left out, and they do
881878
# not compile on their own: each needs a third-party library the wheel links but publishes no

0 commit comments

Comments
 (0)