Skip to content

Commit e06e96d

Browse files
committed
Update
[ghstack-poisoned]
1 parent b422c1c commit e06e96d

2 files changed

Lines changed: 4 additions & 8 deletions

File tree

.ci/scripts/test_cpp_sdk_wheel.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ with zipfile.ZipFile(wheel_file) as wheel:
6565
names = set(wheel.namelist())
6666
6767
required = [
68-
"executorch/lib/libexecutorch.so",
6968
"executorch/share/cmake/executorch-config.cmake",
7069
"executorch/utils/__init__.py",
7170
"executorch/include/executorch/runtime/executor/program.h",
@@ -75,9 +74,8 @@ missing = [name for name in required if name not in names]
7574
if missing:
7675
raise AssertionError(f"{wheel_file} is missing SDK files: {missing}")
7776
78-
# The loader resolves the SONAME (libexecutorch.so.<major>), so a versioned
79-
# real library must be present in addition to the dev symlink. Without it the
80-
# wheel links at build time but fails to load at runtime.
77+
# The loader resolves the SONAME (libexecutorch.so.<major>), which is the only
78+
# runtime library shipped. Without it the wheel has no linkable runtime.
8179
versioned = [
8280
name
8381
for name in names
@@ -87,7 +85,7 @@ versioned = [
8785
if not versioned:
8886
raise AssertionError(
8987
f"{wheel_file} has no versioned libexecutorch.so.<ver>; the SONAME "
90-
"symlink chain is broken and the library will fail to load at runtime."
88+
"library is missing and the runtime cannot load."
9189
)
9290
9391
# Headers whose implementation is not shipped must not be advertised.

setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,9 +1095,7 @@ def run(self): # noqa C901
10951095
# Ship optimized CPU kernels (with portable fallback for uncovered
10961096
# ops) in the standalone kernels .so, so the SDK can run non- or
10971097
# partially-delegated models. Mirrors iOS kernels_optimized.
1098-
cmake_configuration_args += [
1099-
"-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON"
1100-
]
1098+
cmake_configuration_args += ["-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON"]
11011099

11021100
with Buck2EnvironmentFixer():
11031101
# Generate the cmake cache from scratch to ensure that the cache state

0 commit comments

Comments
 (0)