migrate backends/vulkan/tools/gpuinfo (TARGETS+BUCK with similar rules) (#21432)

Summary:

Both files defined the same target names with cell-specific differences
(TARGETS: is_fbcode=True for vulkan_spv_shader_lib, no compiler_flags;
BUCK: extra arvr opencl + folly:json deps, compiler_flags select).
Combined into a new targets.bzl that branches on is_fbcode for the
fb_xplat_cxx_binary, with the buck_filegroup and vulkan_spv_shader_lib
shared.

Reviewed By: ndmitchell

Differential Revision: D109082051

Author: bigfootjon

backends/vulkan/tools/gpuinfo/BUCK

@@ -1,58 +1,9 @@
-load("@fbcode_macros//build_defs:native_rules.bzl", "buck_filegroup")
-load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary")
-load(
-    "@fbsource//tools/build_defs:platform_defs.bzl",
-    "ANDROID",
-)
-load(
-    "@fbsource//xplat/executorch/backends/vulkan:targets.bzl",
-    "vulkan_spv_shader_lib",
-)
+# Any targets that should be shared between fbcode and xplat must be defined in
+# targets.bzl.
 
-oncall("executorch")
-
-buck_filegroup(
-    name = "gpuinfo_shaders",
-    srcs = glob([
-        "glsl/*",
-    ]),
-    visibility = [
-        "PUBLIC",
-    ],
-)
+load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
+load(":targets.bzl", "define_common_targets")
 
-vulkan_spv_shader_lib(
-    name = "gpuinfo_shader_lib",
-    spv_filegroups = {
-        ":gpuinfo_shaders": "glsl",
-    },
-)
+oncall("executorch")
 
-fb_xplat_cxx_binary(
-    name = "vulkan_gpuinfo",
-    srcs = glob([
-        "**/*.cpp",
-    ]),
-    headers = glob([
-        "**/*.h",
-    ]),
-    compiler_flags = select({
-        "DEFAULT": [
-            "-Wno-header-hygiene",
-        ],
-        "ovr_config//compiler:cl": [],
-    }),
-    header_namespace = "/include",
-    include_directories = ["/include"],
-    platforms = ANDROID,
-    raw_headers = glob([
-        "**/*.h",
-    ]),
-    deps = [
-        ":gpuinfo_shader_lib",
-        "//arvr/third-party/opencl:headers",
-        "//arvr/third-party/opencl:runtime",
-        "//xplat/executorch/backends/vulkan:vulkan_graph_runtime",
-        "//xplat/folly:json",
-    ],
-)
+define_common_targets(is_fbcode = is_fbcode())

backends/vulkan/tools/gpuinfo/TARGETS

@@ -0,0 +1,74 @@
+load("@fbcode_macros//build_defs:native_rules.bzl", "buck_filegroup")
+load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary")
+load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID")
+load("@fbsource//xplat/executorch/backends/vulkan:targets.bzl", "vulkan_spv_shader_lib")
+
+def define_common_targets(is_fbcode = False):
+    """Combined fbcode + xplat targets for backends/vulkan/tools/gpuinfo."""
+    buck_filegroup(
+        name = "gpuinfo_shaders",
+        srcs = native.glob([
+            "glsl/*",
+        ]),
+        visibility = [
+            "PUBLIC",
+        ],
+    )
+
+    vulkan_spv_shader_lib(
+        name = "gpuinfo_shader_lib",
+        is_fbcode = is_fbcode,
+        spv_filegroups = {
+            ":gpuinfo_shaders": "glsl",
+        },
+    )
+
+    if is_fbcode:
+        fb_xplat_cxx_binary(
+            name = "vulkan_gpuinfo",
+            srcs = native.glob([
+                "**/*.cpp",
+            ]),
+            headers = native.glob([
+                "**/*.h",
+            ]),
+            header_namespace = "/include",
+            include_directories = ["/include"],
+            platforms = ANDROID,
+            raw_headers = native.glob([
+                "**/*.h",
+            ]),
+            deps = [
+                ":gpuinfo_shader_lib",
+                "//executorch/backends/vulkan:vulkan_graph_runtime",
+            ],
+        )
+    else:
+        fb_xplat_cxx_binary(
+            name = "vulkan_gpuinfo",
+            srcs = native.glob([
+                "**/*.cpp",
+            ]),
+            headers = native.glob([
+                "**/*.h",
+            ]),
+            compiler_flags = select({
+                "DEFAULT": [
+                    "-Wno-header-hygiene",
+                ],
+                "ovr_config//compiler:cl": [],
+            }),
+            header_namespace = "/include",
+            include_directories = ["/include"],
+            platforms = ANDROID,
+            raw_headers = native.glob([
+                "**/*.h",
+            ]),
+            deps = [
+                ":gpuinfo_shader_lib",
+                "//arvr/third-party/opencl:headers",
+                "//arvr/third-party/opencl:runtime",
+                "//xplat/executorch/backends/vulkan:vulkan_graph_runtime",
+                "//xplat/folly:json",
+            ],
+        )