Skip to content

Commit e41f218

Browse files
committed
Fix test-webgpu-native: export the missing rope fixture, raise the job timeout
1 parent 9cd0c12 commit e41f218

3 files changed

Lines changed: 15 additions & 2 deletions

File tree

.github/workflows/test-webgpu-native.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ jobs:
3636
runner: linux.4xlarge.memory
3737
docker-image: ci-image:executorch-ubuntu-22.04-clang12
3838
submodules: recursive
39-
timeout: 120
39+
# The test script alone runs about 60 minutes, and the checkout plus the
40+
# Dawn and SwiftShader source builds in front of it have been measured
41+
# between 18 and 64 minutes on this same runner type, so 120 does not
42+
# cover a slow setup.
43+
timeout: 150
4044
script: |
4145
set -eux
4246

backends/webgpu/scripts/test_webgpu_native_ci.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,8 +106,12 @@ export_rope_model('${ROPE_DECODE_MODEL}', '${ROPE_DECODE_XQ_GOLDEN}', '${ROPE_DE
106106
"
107107

108108
$PYTHON_EXECUTABLE -c "
109-
from executorch.backends.webgpu.test.ops.test_rope_hf import export_rope_hf_dynamic
109+
from executorch.backends.webgpu.test.ops.test_rope_hf import (
110+
export_rope_hf_dynamic,
111+
export_rope_hf_dynamic_sequence,
112+
)
110113
export_rope_hf_dynamic('${ROPE_HF_DIR}')
114+
export_rope_hf_dynamic_sequence('${ROPE_HF_DIR}')
111115
"
112116

113117
$PYTHON_EXECUTABLE -c "
@@ -157,6 +161,7 @@ export_incache_decode('/tmp')
157161
"
158162

159163
require_file "${ROPE_HF_DIR}/rope_hf_dynamic.pte"
164+
require_file "${ROPE_HF_DIR}/rope_hf_dynamic_sequence.pte"
160165
require_file "${SYMINT_BLOB}"
161166
require_file "${OUTPUT_SUPPRESSION_DIR}/input.bin"
162167

backends/webgpu/test/test_native_ci_contract.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,9 @@ def test_requires_dynamic_rope_fixture(self) -> None:
7171
).read_text()
7272

7373
self.assertIn("export_rope_hf_dynamic('${ROPE_HF_DIR}')", script)
74+
self.assertIn("export_rope_hf_dynamic_sequence('${ROPE_HF_DIR}')", script)
7475
self.assertIn('WEBGPU_TEST_ROPE_HF_DIR="${ROPE_HF_DIR}"', script)
7576
self.assertIn('require_file "${ROPE_HF_DIR}/rope_hf_dynamic.pte"', script)
77+
self.assertIn(
78+
'require_file "${ROPE_HF_DIR}/rope_hf_dynamic_sequence.pte"', script
79+
)

0 commit comments

Comments
 (0)