Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to bring your own flatc #9145

Closed
jathu opened this issue Mar 11, 2025 · 3 comments
Closed

Remove the ability to bring your own flatc #9145

jathu opened this issue Mar 11, 2025 · 3 comments
Assignees
@jathu
Labels
actionable Items in the backlog waiting for an appropriate impl/fix good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch

Comments

@jathu
Copy link
Contributor

jathu commented Mar 11, 2025 •
edited by pytorch-bot bot
Loading

We currently build flatc from source, however we also:

  • Allow people to bring their own flatc via the FLATC_EXECUTABLE flag
  • Install flatc from pip for some builds

Given we rely on flatbuffers headers from the one we import, I think we should make this completely hermetic and always build flatc from source.

What are some reasons to allow bringing in flatc?

cc @larryliu0820 @lucylq
@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch good first issue Good for newcomers and removed good first issue Good for newcomers labels Mar 11, 2025
@github-project-automation github-project-automation bot moved this to To triage in ExecuTorch DevX Mar 12, 2025
@tdakhran
Copy link

cross-compilation is one of the reasons, we use FLATC_EXECUTABLE to supply flatc precompiled for host system.

@jathu
Copy link
Contributor Author

jathu commented Mar 13, 2025 •
edited
Loading

@tdakhran that should be fixed once this lands #9077

@jathu jathu added good first issue Good for newcomers actionable Items in the backlog waiting for an appropriate impl/fix labels Mar 13, 2025
@jathu jathu self-assigned this Mar 19, 2025
@jathu
Copy link
Contributor Author

jathu commented Mar 19, 2025

We now build flatc for the host on all platforms: #9077, #9306.

After some thought, I don't want to remove the ability for the user to set FLATC_EXECUTABLE since it provides an escape hatch.

@jathu jathu closed this as completed Mar 19, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in ExecuTorch DevX Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jathu jathu

Labels
actionable Items in the backlog waiting for an appropriate impl/fix good first issue Good for newcomers module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch
Projects
ExecuTorch DevX
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jathu @tdakhran