Skip to content

Conversation

@DrJessop
Copy link
Contributor

Summary:
Ops updated in this diff

  • ReplaceSafeSoftmaxWithSoftmax
  • ReplacePT2QuantWithCadenceQuantPass
  • ReplacePT2DequantWithCadenceDequantPass
  • ReplaceFunctionallyEquivalentOpTargets
  • ReplaceScalarTensorWithFullPass
  • ReplaceFullLikeWithFullPass
  • ReplaceInfArgInFullWithValuePass
  • ReplaceAtenLinalgSvdWithCadenceLinalgSvdPass

Also, removed ReplaceAtenApproxGeluWithApproxGeluPass since it was a NO-OP (not doing what its name suggested).

Differential Revision: D86725366

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15727

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit 3cf70b3 with merge base 58237e9 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 11, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 11, 2025

@DrJessop has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86725366.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:

Ops updated in this diff
- ReplaceSafeSoftmaxWithSoftmax
- ReplacePT2QuantWithCadenceQuantPass
- ReplacePT2DequantWithCadenceDequantPass
- ReplaceFunctionallyEquivalentOpTargets
- ReplaceScalarTensorWithFullPass
- ReplaceFullLikeWithFullPass
- ReplaceInfArgInFullWithValuePass
- ReplaceAtenLinalgSvdWithCadenceLinalgSvdPass

Also, removed ReplaceAtenApproxGeluWithApproxGeluPass since it was a NO-OP (not doing what its name suggested).

Reviewed By: ethansfng

Differential Revision: D86725366
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 11, 2025
Summary:

Ops updated in this diff
- ReplaceSafeSoftmaxWithSoftmax
- ReplacePT2QuantWithCadenceQuantPass
- ReplacePT2DequantWithCadenceDequantPass
- ReplaceFunctionallyEquivalentOpTargets
- ReplaceScalarTensorWithFullPass
- ReplaceFullLikeWithFullPass
- ReplaceInfArgInFullWithValuePass
- ReplaceAtenLinalgSvdWithCadenceLinalgSvdPass

Also, removed ReplaceAtenApproxGeluWithApproxGeluPass since it was a NO-OP (not doing what its name suggested).

Reviewed By: ethansfng

Differential Revision: D86725366
DrJessop pushed a commit to DrJessop/executorch that referenced this pull request Nov 11, 2025
Summary:

Ops updated in this diff
- ReplaceSafeSoftmaxWithSoftmax
- ReplacePT2QuantWithCadenceQuantPass
- ReplacePT2DequantWithCadenceDequantPass
- ReplaceFunctionallyEquivalentOpTargets
- ReplaceScalarTensorWithFullPass
- ReplaceFullLikeWithFullPass
- ReplaceInfArgInFullWithValuePass
- ReplaceAtenLinalgSvdWithCadenceLinalgSvdPass

Also, removed ReplaceAtenApproxGeluWithApproxGeluPass since it was a NO-OP (not doing what its name suggested).

Reviewed By: ethansfng

Differential Revision: D86725366
@meta-codesync meta-codesync bot merged commit 34828bf into pytorch:main Nov 12, 2025
140 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants