Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New production version, likely 0.12.0 #471

Closed
4 of 5 tasks
pc494 opened this issue Mar 26, 2024 · 17 comments
Closed
4 of 5 tasks

New production version, likely 0.12.0 #471

pc494 opened this issue Mar 26, 2024 · 17 comments
Labels
dev Package maintenance
Milestone

Comments

@pc494
Copy link
Member

pc494 commented Mar 26, 2024

With #469 coming in and fixing an important bug with significant downstream (--> diffsims --> pyxem) implication it seems likely we will need a new release of orix. Given what's currently in the changelog this is likely to be a minor release. I'll use this issue to collate what we may (or may not) need to get in before making the release.

Tagged PRs in unclear states

#442
#451
#457
#460

Milestone issues

#439

Outline of plan (in planned order of merges)

I think the others can be left for now.

@pc494 pc494 added the dev Package maintenance label Mar 26, 2024
@pc494
Copy link
Member Author

pc494 commented Mar 26, 2024

For what it's worth, I would be happy to merge #469, deal with the copyright notice and send it to production. The bug being solved by #469 is blocking diffsims and pyxem at the moment.

@CSSFrancis
Copy link
Member

CSSFrancis commented Mar 26, 2024

@pc494 #460 Just needs a review. I think that one should be good to go.

We should do #472 Just to help us get some of the other things in. I can help review but can't directly clean up others work to help get things merged which is likely the path we would have to take to get this released quickly.

More smaller releases is good.

@CSSFrancis CSSFrancis pinned this issue Mar 26, 2024
@hakonanes
Copy link
Member

I agree that a swift minor release is good. I'll have a look at the docs.

@pc494
Copy link
Member Author

pc494 commented Mar 31, 2024

Is it worth putting out a release candidate while we wait for some progress on #475?

@CSSFrancis
Copy link
Member

@pc494 or @hakonanes Do you want to make a release? I can do it as well if you would like.

@hakonanes
Copy link
Member

If it's OK with you I'd like to do it this evening after looking over the latest changes.

@pc494
Copy link
Member Author

pc494 commented Apr 2, 2024

If it's OK with you I'd like to do it this evening after looking over the latest changes.

This works for me :)

@hakonanes hakonanes added this to the v0.12.0 milestone Apr 2, 2024
@hakonanes
Copy link
Member

I'll have to look over the docs before release, which I'll do tomorrow evening. Hence, I can make the release then at the earliest.

If you would like to give feedback on the changes, we should wait until Thursday.

@pc494
Copy link
Member Author

pc494 commented Apr 3, 2024

#478 looks good so far. I could look over changes Thursday morning UK time, would it be okay @hakonanes for you to set stuff up this evening and then (assuming all goes well) make a release on Thursday evening?

@hakonanes
Copy link
Member

Assuming all checks pass, #478 is done. It just needs a review. I'm OK with releasing after that.

What do you mean by the TODO called "deps" in the top comment, @pc494? Is it a check for minimal supported versions?

@hakonanes
Copy link
Member

Regarding minimal supported versions (Python 3.7), see #482.

@CSSFrancis
Copy link
Member

#483 Should be included as well to support numpy 2.0.0

@hakonanes
Copy link
Member

I've opened #487 to bring all changes since the last release onto the main branch for tagging and releasing.

@hakonanes
Copy link
Member

It's on PyPI: https://pypi.org/project/orix/.

Waiting for conda-forge. This evening or tomorrow morning.

@hakonanes
Copy link
Member

Other updates:

@hakonanes
Copy link
Member

For some unexplicable reason, our build action

- name: Build package
run: |
python -m build

created a distribution file with name orix-0.12.tar.gz, without the patch number. It has always included that before. The version is listed and interpreted correctly all other places I've looked.

Our conda-forge feedstock build therefore failes, because it looks for orix-0.12.0.tar.gz and can't find it. I had to add a temporary_version parameter to the meta.yaml script to temporarily point conda-forge to the orix-0.12.tar.gz file. This must be removed when releasing a new version!

@hakonanes
Copy link
Member

It's on conda-forge: https://anaconda.org/conda-forge/orix.

@hakonanes hakonanes unpinned this issue Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Package maintenance
Projects
None yet
Development

No branches or pull requests

3 participants