-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New production version, likely 0.12.0 #471
Comments
@pc494 #460 Just needs a review. I think that one should be good to go. We should do #472 Just to help us get some of the other things in. I can help review but can't directly clean up others work to help get things merged which is likely the path we would have to take to get this released quickly. More smaller releases is good. |
I agree that a swift minor release is good. I'll have a look at the docs. |
Is it worth putting out a release candidate while we wait for some progress on #475? |
@pc494 or @hakonanes Do you want to make a release? I can do it as well if you would like. |
If it's OK with you I'd like to do it this evening after looking over the latest changes. |
This works for me :) |
I'll have to look over the docs before release, which I'll do tomorrow evening. Hence, I can make the release then at the earliest. If you would like to give feedback on the changes, we should wait until Thursday. |
#478 looks good so far. I could look over changes Thursday morning UK time, would it be okay @hakonanes for you to set stuff up this evening and then (assuming all goes well) make a release on Thursday evening? |
Regarding minimal supported versions (Python 3.7), see #482. |
#483 Should be included as well to support |
I've opened #487 to bring all changes since the last release onto the |
It's on PyPI: https://pypi.org/project/orix/. Waiting for conda-forge. This evening or tomorrow morning. |
Other updates:
|
For some unexplicable reason, our build action orix/.github/workflows/python-publish.yml Lines 39 to 41 in 8620292
created a distribution file with name orix-0.12.tar.gz, without the patch number. It has always included that before. The version is listed and interpreted correctly all other places I've looked. Our conda-forge feedstock build therefore failes, because it looks for orix-0.12.0.tar.gz and can't find it. I had to add a |
It's on conda-forge: https://anaconda.org/conda-forge/orix. |
With #469 coming in and fixing an important bug with significant downstream (--> diffsims --> pyxem) implication it seems likely we will need a new release of orix. Given what's currently in the changelog this is likely to be a minor release. I'll use this issue to collate what we may (or may not) need to get in before making the release.
Tagged PRs in unclear states
#442
#451
#457
#460
Milestone issues
#439
Outline of plan (in planned order of merges)
I think the others can be left for now.
The text was updated successfully, but these errors were encountered: