Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary PyCIFRW dependency #510

Open
hakonanes opened this issue Sep 2, 2024 · 2 comments
Open

Temporary PyCIFRW dependency #510

hakonanes opened this issue Sep 2, 2024 · 2 comments
Labels
bug Something isn't working dev Package maintenance

Comments

@hakonanes
Copy link
Member

We must add PyCIFRW as a dependency until it again comes automatically by installing diffpy.structure from PyPI. See diffpy/diffpy.structure#97. Will do this for the upcoming v0.13.0.

@hakonanes hakonanes added bug Something isn't working dev Package maintenance labels Sep 2, 2024
@hakonanes
Copy link
Member Author

The diffpy guys fixed this in:

We can get rid of the explicit PyCIFRW dependency once a new patch v3.2.1 for diffpy.structure is released :)

@hakonanes
Copy link
Member Author

Only diffpy.structure v3.1 is available from conda-forge, which means we get all necessary dependencies as well when running conda install diffpy.structure -c conda-forge. But just for good measure, until we can restrict diffpy.structure>=3.2.1 on conda-forge, I'll list PyCIFRW there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Package maintenance
Projects
None yet
Development

No branches or pull requests

1 participant