Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fetching live resources in downloader middleware #9

Open
leewesleyv opened this issue Oct 22, 2024 · 1 comment
Open

Support fetching live resources in downloader middleware #9

leewesleyv opened this issue Oct 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@leewesleyv
Copy link
Collaborator

leewesleyv commented Oct 22, 2024

When using the downloader middleware and the request is not found, request the live resource. Add a setting or something alike that we can use the control this behaviour.

@leewesleyv leewesleyv changed the title When using the downloader middleware and the request is not found, request the live resource Support fetching live resources in downloader middleware Oct 22, 2024
@leewesleyv leewesleyv added the enhancement New feature or request label Oct 22, 2024
@wvengen
Copy link
Member

wvengen commented Oct 22, 2024

Great idea. I would say this is ok to leave this for after the package has been published.

When you want to crawl the resulting WACZ (containing new resources), you probably want to crawl it together with the other WACZ (containing older resources). And if the old WACZ also was crawled as an 'update' to a previous one, you need to specify all of them when crawling it.

I think creating a WACZ manifest could help with this, so you can reference one file to re-crawl. Its specification is a work-in-progress, but a tool like replayweb.page already supports it afaik - see webrecorder/specs#112 for the spec in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants