Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-file support #9

Open
4 tasks
GollyTicker opened this issue Apr 16, 2022 · 1 comment
Open
4 tasks

Multi-file support #9

GollyTicker opened this issue Apr 16, 2022 · 1 comment
Labels
enhancement New feature or request good-next-issue This issue is a good candidate for soon implementation

Comments

@GollyTicker
Copy link
Collaborator

GollyTicker commented Apr 16, 2022 •
edited by qa-swaneet-sahoo
Loading

Currently, the request and response messages need to be in the same file. An improvement would be to allow the user to import a directory of Protobuf files (or multiple directories) and have protoCURL search for the definitions given the request and response types.

In fact, protoc accepts multiple files as input directly and is not limited to a single one.

  • decide how the user interface should look like (needs concrete usecase)
  • write tests for this kind of usage
  • implementation in Go
  • add to documenation and EXAMPLES.md
@GollyTicker GollyTicker added the enhancement New feature or request label Apr 16, 2022
@GollyTicker
Copy link
Collaborator Author

Partially implemented in #11, since protoc allows for multiple proto files as arguments.

However, having the request and response message in different files is not explicitly tested yet.

@qa-swaneet-sahoo qa-swaneet-sahoo added the good-next-issue This issue is a good candidate for soon implementation label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-next-issue This issue is a good candidate for soon implementation
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GollyTicker @qa-swaneet-sahoo