Add "Created On" column to transfer list #23647
Conversation
src/gui/transferlistmodel.h
Outdated
| TR_POPULARITY, | ||
| TR_CATEGORY, | ||
| TR_TAGS, | ||
| TR_CREATE_DATE, |
There was a problem hiding this comment.
IIRC you can only add new values to the end of the list, otherwise it affects existing user's setting. Something like user will see the visible columns are not the same columns as before.
There was a problem hiding this comment.
I had thought about that and wasn't sure if something like that might be an issue, but after looking at the ordering/grouping of the current values, it seemed like similar things were being grouped together and putting this in with the other date-based values would be the "right" answer. I also didn't have any issues in testing, although my testing wasn't very thorough and was using "out-of-the-box" setup.
I can move this if needed (it doesn't make me any difference) but it might be good to clarify if it's really necessary since that would go against how things are currently setup here (with all date-based values being grouped together).
There was a problem hiding this comment.
I also didn't have any issues in testing, although my testing wasn't very thorough and was using "out-of-the-box" setup.
Follow these steps to reproduce the issue:
- Create a new/clean profile and start qbt v5.1.4.
- Show only these columns:
Tags,Added On,Availability. Hide the others. - Close qbt v5.1.4.
- Start qbt nightly (the one from your PR)
- Now these columns are shown:
Tags,Created On,Last Activity,Private.
The expected shown columns should be Tags, Added On, Availability, Private. The Created On and Last Activity columns should still be hidden.
I can move this if needed (it doesn't make me any difference) but it might be good to clarify if it's really necessary since that would go against how things are currently setup here (with all date-based values being grouped together).
This is a known issue and the easiest workaround is what I suggested in my post above. IMO is isn't worth to complicate it since users can still freely move the columns manually.
|
I saw this was approved a little while ago but hasn't been merged yet. Is there anything else I need to do here? Any rough idea when this might be included in a release? I'm not trying to be pushy or anything, I just don't know what the release process/timeline is like and am curious when this might be included in an official release (ex. if it might be soonish/later this month, or if this will still be a few months out). |
|
#23647 (comment) isn't resolved yet. |
Workaround to avoid issues with existing client column config that is dependent on the current ordering of members described here: qbittorrent#23647 (comment)
|
Thanks for the quick responses! I've made changes that should address the feedback. |
aaron-kruse
force-pushed
the
add-created-column
branch
from
c73e369 to
68bead0
Compare
Workaround to avoid issues with existing client column config that is dependent on the current ordering of members described here: qbittorrent#23647 (comment)
This column makes the torrent's "Created On" date/time available in the main transfer list for sorting and better visibility.
Workaround to avoid issues with existing client column config that is dependent on the current ordering of members described here: qbittorrent#23647 (comment)
aaron-kruse
force-pushed
the
add-created-column
branch
from
68bead0 to
f5eeb64
Compare
5 participants
Makes the torrent's "Created On" date/time available (but hidden by default) in the main transfer list for sorting and better visibility.
Unlike the "Added On" column (which shows when a torrent was added to the client's list), this shows the date the torrent file was originally created. This is something that can help prioritize which torrents to seed. I have a long list of torrents and looking at each one's properties for the "Created On" date isn't feasible. With the addition of this column, I can just sort by it and bring the oldest torrents to the top of the list. Similarly, I can sort by the number of seeders to find which torrents could use some help the most, then glance at the "Created On" column (ex. I'd rather seed torrents from 10+ years ago that are struggling due to age/availability vs. ones from a few weeks ago that have been replaced by newer/better options). This column could also help with cleaning up your list of torrents by making them easier to work with based on their actual age (and not date added/completed).
I should also maybe mention that this is my first submission here, so hopefully I've followed all the guidelines correctly. I added this column using other similar columns as an example and everything seems to be working fine, but if I missed anything less obvious, please let me know!
Screenshot for reference:
