Add case-sensitive toggle for Find/Replace #924
Labels
est:Minor
Minor effort to implement
est:Score=3
Score for estimate of effort required (scale of 1 upwards)
support:Approved
Approved to be done under the support agreement
support
This issue is a candidate to complete under the support agreement
Milestone
Comments
ghost
added
est:Minor
|
Sounds reasonable for this support release @mattRedBox. @markwheels suggest this is labelled |
markwheels
added
the
support:Approved
|
Thanks @mattRedBox and @Stephen-Gates. I have marked this issue 'support:Approved'. |
ghost
pushed a commit
that referenced
this issue
Jun 30, 2019
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics). Signed-off-by: Matthew Mulholland <[email protected]>
ghost
pushed a commit
that referenced
this issue
Jun 30, 2019
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
|
Confirmed working in 1.1 beta |
ghost
pushed a commit
that referenced
this issue
Apr 21, 2021
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
ghost
pushed a commit
that referenced
this issue
Apr 21, 2021
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics). Signed-off-by: Matthew Mulholland <[email protected]>
ghost
pushed a commit
that referenced
this issue
Apr 21, 2021
… to lock. Separated logic from main's url to frictionless for easier re-use. Added submenu items for both file and url. Improved style to suit open. Allowed title to change. Closes #742. Closes #731. Added Import Column Properties to file disable/enable list. Closes #924: Enabled difference between case-insensitive (with diacritics) and case-sensitive (without diacritics).
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following work on #705, keeping Find and Replace consistent, it may be beneficial to allow the user to toggle this behaviour.
When this work begins, both find and replace will be case insensitive. One of the reasons for this is that there is support for 'diacritics' built in (important for other language use), which use library that hardcodes various glyphs/characters to our regular English alphabet. Trying to split this out into what should/would be lowercase or uppercase is subjective (e.g., pick which one of these you would deem as uppercase 'I' or lowercase 'i' or something else entirely: ḭƗɨɨ̆ᵻᶖİiIıɪ )
While I don't think case sensitivity will solve the problem just listed, a user will at least be able to just distinguish between 'lowercase' and 'uppercase' in regular alphabet. Mucking around with what diacritics would or wouldn't be supported by such a toggle, say in a user preference, would be out of scope for this ticket.
The text was updated successfully, but these errors were encountered: