Skip to content

Commit 4d52abd

Browse files
authored
Fix venv occasional issue (#272)
* Fix venv occasional issue * Fix index error
1 parent 46aed7a commit 4d52abd

File tree

3 files changed

+23
-26
lines changed

3 files changed

+23
-26
lines changed

ansible/playbooks/roles/run-hnsw-indexing-transform/files/run-bench.sh

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,22 @@ fi
3535

3636
cd "${WORK_DIR}"
3737

38-
# Check if venv exists
39-
if [ ! -d "${WORK_DIR}/venv" ]; then
40-
echo "Creating virtual environment..."
41-
python3 -m venv "${WORK_DIR}/venv"
42-
source "${WORK_DIR}/venv/bin/activate"
43-
44-
echo "Installing requirements..."
45-
pip install -r "${WORK_DIR}/requirements.txt"
46-
47-
deactivate
48-
else
49-
echo "Virtual environment already exists. Skipping setup."
38+
# Remove existing venv if present
39+
if [ -d "${WORK_DIR}/venv" ]; then
40+
echo "Removing existing virtual environment..."
41+
rm -rf "${WORK_DIR}/venv"
5042
fi
5143

44+
# Create and setup virtual environment
45+
echo "Creating virtual environment..."
46+
python3 -m venv "${WORK_DIR}/venv"
47+
5248
echo "Activating virtual environment..."
5349
source "${WORK_DIR}/venv/bin/activate"
5450

51+
echo "Installing requirements..."
52+
pip install -r "${WORK_DIR}/requirements.txt"
53+
5554
NOW=$(date "+%Y-%m-%dT%H:%M:%SZ")
5655
echo "${NOW}"
5756
echo "Running..."

ansible/playbooks/roles/run-hnsw-indexing-transform/files/transform.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
TEST_DATA_FILE_2 = DATA_DIR_2 / "tests.jsonl"
3838
TEST_DATA_FILE_1 = DATA_DIR / "tests.jsonl"
3939

40-
TOTAL_VECTORS = 100_000
4140
BATCH_SIZE = 500
4241

4342

@@ -176,7 +175,7 @@ def main():
176175
result["initial_precision"] = initial_precision
177176
result["precision_before_iteration"] = initial_precision
178177

179-
points_to_migrate = list(range(TOTAL_VECTORS))
178+
points_to_migrate = list(range(len(vectors_1)))
180179

181180
random.shuffle(points_to_migrate)
182181

ansible/playbooks/roles/run-hnsw-indexing-update/files/run-bench.sh

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,23 +31,22 @@ fi
3131

3232
cd "${WORK_DIR}"
3333

34-
# Check if venv exists
35-
if [ ! -d "${WORK_DIR}/venv" ]; then
36-
echo "Creating virtual environment..."
37-
python3 -m venv "${WORK_DIR}/venv"
38-
source "${WORK_DIR}/venv/bin/activate"
39-
40-
echo "Installing requirements..."
41-
pip install -r "${WORK_DIR}/requirements.txt"
42-
43-
deactivate
44-
else
45-
echo "Virtual environment already exists. Skipping setup."
34+
# Remove existing venv if present
35+
if [ -d "${WORK_DIR}/venv" ]; then
36+
echo "Removing existing virtual environment..."
37+
rm -rf "${WORK_DIR}/venv"
4638
fi
4739

40+
# Create and setup virtual environment
41+
echo "Creating virtual environment..."
42+
python3 -m venv "${WORK_DIR}/venv"
43+
4844
echo "Activating virtual environment..."
4945
source "${WORK_DIR}/venv/bin/activate"
5046

47+
echo "Installing requirements..."
48+
pip install -r "${WORK_DIR}/requirements.txt"
49+
5150
NOW=$(date "+%Y-%m-%dT%H:%M:%SZ")
5251
echo "${NOW}"
5352
echo "Running..."

0 commit comments

Comments
 (0)