Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core/UI] Add TARGET_ARCGIS_VERSION option for OpenFileGDB, and add GUI hints when using it #58705

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[core/UI] Add TARGET_ARCGIS_VERSION option for OpenFileGDB, and add GUI hints when using it #58705

merged 2 commits into from
Sep 17, 2024

Conversation

rouault
Copy link
Contributor

@rouault rouault commented Sep 12, 2024

Fixes #58690

image

@github-actions github-actions bot added this to the 3.40.0 milestone Sep 12, 2024
rouault added a commit to rouault/QGIS that referenced this pull request Sep 12, 2024
@rouault
QgsVectorLayerSaveAsDialog: use correct test for question
a02555b 
This doesn't fix a real issue, since that code path is unlikely to be
taken, but when creating qgis#58705, I
copied&pasted this wrong code, and was wondering why clicking on No had
the same effect as Yes...
@rouault rouault mentioned this pull request Sep 12, 2024
Merged
@github-actions GitHub Actions
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 0eb5d6e)

@agiudiceandrea
Copy link
Member

agiudiceandrea commented Sep 12, 2024 •
edited
Loading

Great! Thanks!
Have you seen #58669 about an issue in the attribute table that occurs with OpenFileGDB and not with FileGDB? oops!

@rouault
Copy link
Contributor Author

rouault commented Sep 12, 2024

Have you seen #58669 about an issue in the attribute table that occurs with OpenFileGDB and not with FileGDB?

seems totally unrelated with this PR...

@nyalldawson nyalldawson added Freeze Exempt Feature Freeze exemption granted and removed backport release-3_38 labels Sep 13, 2024
velle pushed a commit to velle/QGIS that referenced this pull request Sep 17, 2024
@rouault @velle
QgsVectorLayerSaveAsDialog: use correct test for question
e4296c0 
This doesn't fix a real issue, since that code path is unlikely to be
taken, but when creating qgis#58705, I
copied&pasted this wrong code, and was wondering why clicking on No had
the same effect as Yes...
@nyalldawson nyalldawson merged commit 0240c8b into qgis:master Sep 17, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson approved these changes

Assignees
No one assigned
Labels
Freeze Exempt Feature Freeze exemption granted
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.

Export of geopackage to File Geodatabase creates fid type real causing subsequent vector conversions to fail.
3 participants
@rouault @agiudiceandrea @nyalldawson