QuantinuumJob response is sometimes JobStatus #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cation per stack trace in issue ticket
|
|
|
Just want to mention that this PR is a continuation of the recent fix from #28. I've tested this on my end and would find this being merged in fyi @1ucian0 / @mtreinish |
mtreinish
reviewed
Jun 16, 2023
|
Just following up on this PR. It looks like @WrathfulSpatula made the requested change asked by @mtreinish . Are there any other outstanding issues you think would be worth addressing, or is this okay to be merged into Thanks again! |
|
@1ucian0 @chris-theroux @mtreinish Any chance this can be merged into |
|
I don't have permissions to merge. Pinging @mtreinish |
vprusso
added a commit
to unitaryfund/qiskit-quantinuum-provider
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Closes #27)
Over at https://github.com/SRI-International/QC-App-Oriented-Benchmarks, we're trying to use this provider to benchmark Quantinuum devices. However, adding the provider to that repository, it always raises an exception due to an unhandled case in the method
status(), where one or more items inself._experiment_resultsis aJobStatusinstance.Following your logic in the same region of code, we extract the maximum information we can for the
experiment_result, then we add the header and append to the results list otherwise exactly according to how it was already done.This fixes our issue in the benchmarks repository, allowing us to get the results we expect.
Details and comments
For coverage: I can see that the original code leads to an exception and stack trace in https://github.com/SRI-International/QC-App-Oriented-Benchmarks, while the code is this branch works. I'm not sure how to encapsulate this in a unit test, but, apparently, the original code coverage didn't cover this logical case, of a
JobStatusresponse.