address comments

qjia7 · qjia7 · commit 65f65759e6bd · 2024-11-05T13:04:49.000+08:00
diff --git a/js/web/lib/wasm/jsep/webgpu/ops/reduce-shared.ts b/js/web/lib/wasm/jsep/webgpu/ops/reduce-shared.ts
@@ -192,6 +192,7 @@ export const createReduceSharedProgramInfo = (
   // One work group is responsible for only one element of output.
   return {
     name,
+    // Note that in JSEP, WG size is not included in cache by default, but WebGPU EP it is.
     shaderCache: { hint: `${cacheKey};${workgroupSize}`, inputDependencies: ['type'] },
     getShaderSource,
     getRunData: () => ({
diff --git a/js/web/lib/wasm/jsep/webgpu/ops/softmax.ts b/js/web/lib/wasm/jsep/webgpu/ops/softmax.ts
@@ -159,6 +159,7 @@ const createSoftmaxProgramInfo = (context: ComputeContext, attributes: SoftmaxAt
   const result = context.compute(
     {
       name: 'Softmax',
+      // Note that in JSEP, WG size is not included in cache by default, but WebGPU EP it is.
       shaderCache: { hint: `${components};${WG}`, inputDependencies: ['type'] },
       getRunData: () => ({
         outputs: [{ dims: transposedInputShape, dataType: transposedInput.dataType }],

Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,7 @@ const createSoftmaxProgramInfo = (context: ComputeContext, attributes: SoftmaxAt`
`159`	`159`	`const result = context.compute(`
`160`	`160`	`{`
`161`	`161`	`name: 'Softmax',`
	`162`	`+ // Note that in JSEP, WG size is not included in cache by default, but WebGPU EP it is.`
`162`	`163`	shaderCache: { hint: `${components};${WG}`, inputDependencies: ['type'] },
`163`	`164`	`getRunData: () => ({`
`164`	`165`	`outputs: [{ dims: transposedInputShape, dataType: transposedInput.dataType }],`