Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] LED configuration #1297

Open
flpcstrike opened this issue Aug 10, 2023 · 5 comments
Open

[Feature Request] LED configuration #1297

flpcstrike opened this issue Aug 10, 2023 · 5 comments

Comments

@flpcstrike
Copy link

flpcstrike commented Aug 10, 2023

Description

For someone like me which lacks programing skills and could not manage to edit or configure the lights with msys, having basic LED configuration would be a really nice QoL feature to have in the online configurator.

For example:
Solid colour selection without any crazy rgb matrix effects. (Locking the keyboard to a single colour.)
Selection of which lights to enable/disable. (Like the side lights on gmmk models.)
Caps lock colour change option when its enabled.

@zvecr zvecr transferred this issue from qmk/qmk.fm_old Aug 11, 2023
@flpcstrike
Copy link
Author

Keycodes in the keyboard settings tab needs to be updated, as I just noticed that "RGB_MODE_PLAIN", "RBG_HUD" and "RBG_HUI" are now deprecated.

It would also be nice if the "RGB_MODE_PLAIN" keycode was restored or updated, as I can't seem to find the new keycode for this toggle, and having to cycle through every single rbg animation to get to plain single color mode seems a bit odd.

@fauxpark
Copy link
Member

fauxpark commented Dec 19, 2024

When I split up the RGB keycodes recently into UG_ for RGBLight/Underglow and RM_ for RGB Matrix, I decided not to migrate these keycodes. They are deprecated and will be removed soon.

Not all of their respective effects may be enabled (so it is not guaranteed they will do anything), and it is impractical to keep parity with the complete list of effects, particularly for RGB Matrix, which has a very large number of possible animations. Some of the keycodes were mapped to "close" equivalents to the existing RGBLight effects, but mostly there are/were no keycodes for the majority of them.

RGB_HUD/RGB_HUI have been renamed to UG_HUED/UG_HUEU (for RGBLight), or RM_HUED/RM_HUEU (for RGB Matrix). Similar for the remaining RGB keycodes.

@flpcstrike
Copy link
Author

flpcstrike commented Dec 19, 2024

While I can understand the decision to not keep the keycodes for every single rgb effect, I can't understand the decision to remove the keycode that puts the LEDs into static mode without any kind of rgb effect enabled.

RGB_HUD/RGB_HUI have been renamed to UG_HUED/UG_HUEU (for RGBLight), or RM_HUED/RM_HUEU (for RGB Matrix).

I did notice that when looking up the keycodes when neither my old layout or online configurator codes worked as they are both deprecated, however, when changing the old keycodes into anykey and manually adding the new keycodes they initially didn't work.

Managed to fix it now by using UG_PREV/UG_NEXT, UG_SATD/ UG_SATU and UG_HUED/UG_HUEU, but it is a bit annoying having to toggle between every single rgb effect, hue and saturation. The ability to force a single rgb mode like a static color and rgb value/hex in the online configurator would be very nice to have.

@fauxpark
Copy link
Member

fauxpark commented Dec 19, 2024

For both RGBLight and RGB Matrix, the "static colour" effect is always enabled and cannot be disabled. If a board has no effects enabled, and the internal config is somehow pointing at some other effect, then that is an invalid state; hitting the prev/next keycodes should fix it. (though I would expect QMK to automatically detect this and rectify it anyway).

There have never been any keycodes to enforce a particular colour, only a particular effect.

I agree the keycode names here on the Configurator need to be updated.

@flpcstrike
Copy link
Author

For both RGBLight and RGB Matrix, the "static colour" effect is always enabled and cannot be disabled.

Yes, but RGB_MODE_PLAIN doesn't work anymore, resulting in having to cycle through every rgb effect to find plain single color mode.

There have never been any keycodes to enforce a particular colour, only a particular effect.

As the initial issue is a feature request about LED control in the online configurator, I thought it was obvious that I was talking about the ability to force an rgb mode and rgb value/hex in the online configurator, as well as me mentioning that it would be a nice feature to have specifically in the online configurator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants