Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asserting a schema attribute must require presence of minimal set of attributes #16

Open
gburd opened this issue Aug 6, 2020 · 1 comment

Comments

@gburd
Copy link

gburd commented Aug 6, 2020

These assertions are legit:

[[:db/add "testProp" :db/ident :testProp]]

and:

[:db/add "testProp" :db/ident :testProp]
[:db/add "testProp :db/valueType :db.type/string]
[:db/add "testProp :add/cardinality :db.cardinality/one]]

However, assertion sets which are missing one of the required attributes, such as:

[:db/add "testProp" :db/ident :testProp]
[:db/add "testProp :db/valueType :db.type/string]]

should be illegal.

Similarly,

[[:db/add "testProp :db/valueType :db.type/string]
[:db/add "testProp :add/cardinality :db.cardinality/one]]

should also be illegal.

Original by @grigoryk

@gburd
Copy link
Author

gburd commented Aug 6, 2020

This is relevant to mozilla#796 in spirit, although should require much less changes to implement.

Original by @grigoryk

gburd pushed a commit that referenced this issue May 3, 2022
Update petgraph requirement from ~0.5 to ~0.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant