QDir::listSeparator() and make windeployqt work in linux-mingw. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
socketpair
commented
Dec 1, 2021
| @@ -1648,7 +1648,7 @@ int main(int argc, char **argv) | |||
| const QByteArray qtBinPath = QFile::encodeName(QDir::toNativeSeparators(QCoreApplication::applicationDirPath())); | |||
| QByteArray path = qgetenv("PATH"); | |||
| if (!path.contains(qtBinPath)) { // QTBUG-39177, ensure Qt is in the path so that qt.conf is taken into account. | |||
| path += ';'; | |||
| path += QDir::listSeparator(); | |||
There was a problem hiding this comment.
Actually this is the BUG. THis bug fixes windeployqt under linux.
Please tell me how can I make the fix for Qt 5.15.x ? is it possible ?
|
Sorry, guys, I did not even try to build. Possibly this does not compile. Please review. |
socketpair
force-pushed
the
windeployqt
branch
from
15cdcff
to
fcc2459
Compare
|
Qt doesn't use GitHub, this needs to be submitted to Gerrit codereview (https://codereview.qt-project.org/). For instructions see: https://wiki.qt.io/Setting_up_Gerrit and https://wiki.qt.io/Gerrit_Introduction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.