Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better way to prevent style leak than use lots of important tags #15

Open
quantuminformation opened this issue Aug 15, 2017 · 6 comments

Comments

@quantuminformation
Copy link
Owner

EG

image

@akashdsouza
Copy link
Contributor

May be BEM?

@quantuminformation
Copy link
Owner Author

That wouldn't stop style leak from the parent doc.

@akashdsouza
Copy link
Contributor

Perhaps a name for test recorder and replacing class names such as header to -test-recorder__header?
Just suggesting.

@akashdsouza
Copy link
Contributor

material-ui inlines all the styles without any class names

@quantuminformation
Copy link
Owner Author

Can you explain more how this relates to this project thx.

@akashdsouza
Copy link
Contributor

The styles used for the test recorder shouldn't affect the web page and the styles from the web page should be overwritten by the test recorder's styles. Furthermore, most styles pertaining to the recorder itself are nonreusable. So using inline styles may be better suited than having classes. This means !important will no longer be needed. One downside is the lack of clarity when all the styles are inlined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants