Skip to content

Commit bf75906

Browse files
committed
Rename nightly pytest workflow
Changes: * Use a leading underscore in the file name, because that seems to be more conventional in other repos using sub-workflows. * Rename the run-name of the workflow itself to be more accurate and informational.
1 parent 88a944f commit bf75906

File tree

2 files changed

+35
-5
lines changed

2 files changed

+35
-5
lines changed

.github/workflows/nightly-pytest.yaml renamed to .github/workflows/_nightly-cirq-test.yaml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,10 @@
1717
# This workflow expects input values passed by nightly.yml.
1818
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1919

20-
name: 'Nightly tests & scans – Pytest matrix'
21-
run-name: Run nightly Pytest
20+
# The tilde is only to make our sub-workflows be listed last in the GitHub UI.
21+
name: '~ Cirq version tests'
22+
run-name: >-
23+
Run tests using the ${{inputs.cirq-release}} version of Cirq ${{inputs.reason}}
2224
2325
on:
2426
workflow_call:
@@ -27,10 +29,14 @@ on:
2729
args:
2830
type: string
2931
required: false
30-
# Why is this workflow being called?
32+
# (For the job name) Why is this workflow being called?
3133
reason:
3234
type: string
3335
required: false
36+
# (For the job name) What version of Cirq will be used?
37+
cirq-release:
38+
type: string
39+
required: false
3440

3541
# Allow manual invocation.
3642
workflow_dispatch:

.github/workflows/nightly.yaml

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,38 @@ permissions: read-all
3434
jobs:
3535
cirq-stable:
3636
name: Nightly Pytest Cirq stable
37-
uses: ./.github/workflows/nightly-pytest.yaml
37+
uses: ./.github/workflows/_nightly-cirq-test.yaml
3838
with:
3939
args: ''
4040
reason: '(nightly)'
41+
cirq-release: 'stable'
4142

4243
cirq-pre:
4344
name: Nightly Pytest Cirq pre-release
44-
uses: ./.github/workflows/nightly-pytest.yaml
45+
uses: ./.github/workflows/_nightly-cirq-test.yaml
4546
with:
4647
args: '--pre'
4748
reason: '(nightly)'
49+
cirq-release: 'pre-release'
50+
51+
codeql:
52+
name: Nightly CodeQL code scan
53+
uses: ./.github/workflows/codeql.yaml
54+
permissions: write-all
55+
with:
56+
reason: '(nightly)'
57+
58+
osv:
59+
name: Nightly OSV code scan
60+
uses: ./.github/workflows/osv-scanner.yaml
61+
permissions: write-all
62+
with:
63+
reason: '(nightly)'
64+
65+
scorecard:
66+
name: Nightly Scorecard analysis
67+
uses: ./.github/workflows/scorecard.yaml
68+
permissions: write-all
69+
secrets: inherit
70+
with:
71+
reason: '(nightly)'

0 commit comments

Comments
 (0)