Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I believe that nbdev / quarto doesn't fully work with a windows system. #9409

Closed
ronfan opened this issue Apr 18, 2024 · 4 comments
Closed
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@ronfan
Copy link

ronfan commented Apr 18, 2024

nbdev_install_quarto doesn't seem to work within a windows system.

This is the error code that I received when I attempted nbdev_install_quarto from pip install:

User

PS C:\Users\RongFangLi\test> nbdev_new --lib_name test_repo
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Users\RongFangLi\anaconda3\Scripts\nbdev_new.exe\__main__.py", line
 4, in <module>
  File "C:\Users\RongFangLi\anaconda3\Lib\site-packages\nbdev\cli.py", line 13
, in <module>
    from .quarto import nbdev_readme, refresh_quarto_yml
  File "C:\Users\RongFangLi\anaconda3\Lib\site-packages\nbdev\quarto.py", line
 6, in <module>
    from os import system, uname
ImportError: cannot import name 'uname' from 'os' (C:\Users\RongFangLi\anacond
a3\Lib\os.py)

Steps to reproduce

Follow this guide on a windows 10 system:
https://nbdev.fast.ai/getting_started.html

Expected behavior

No error

Actual behavior

Error code above

Your environment

Windows 10 system on a standard i7 Lenovo laptop

Quarto check output

There was no other output other than the error message above. I believe it is simply a issue because the package is produced with Linux and Mac system in mind.

@ronfan ronfan added the bug Something isn't working label Apr 18, 2024
@mcanouil
Copy link
Collaborator

mcanouil commented Apr 18, 2024

@ronfan Please edit the title of your report and your report itself to be meaningful and useful.
Also, please fill the different section properly and use the formatting tools provided by GitHub to make it legible, e.g., use code blocks for code.

Currently, we cannot use or help you with the current state of your report.
Thank you for your understanding and for providing all the informations requested in the issue template.

@mcanouil mcanouil added the invalid This doesn't seem right label Apr 18, 2024
@ronfan
Copy link
Author

ronfan commented Apr 18, 2024

@ronfan Please edit the title of your report and your report itself to be meaningful and useful. Also, please fill the different section properly and use the formatting tools provided by GitHub to make it legible, e.g., use code blocks for code.

Currently, we cannot use or help you with the current state of your report. Thank you for your understanding and for providing all the informations requested in the issue template.

Hi apologies this is now updated.

@ronfan ronfan changed the title I believe that this doesn't fully work with a windows system. I believe that nbdev / quarto doesn't fully work with a windows system. Apr 18, 2024
@mcanouil
Copy link
Collaborator

mcanouil commented Apr 18, 2024

I don't believe Quarto team is even responsible of nbdev commands.
To me, it seems to be something to discuss with them.

@cscheid Are we doing something here?

PS/Edit: @ronfan you should not report everywhere are the same time the same issue without having developers feedback8 first. Here you are costing time on both side at the same time.

@ronfan
Copy link
Author

ronfan commented Apr 18, 2024

Right, apologies for the time wasted. This seem to be a nbdev issue I'll attempt at closing this post
In case anyone else faced the same issues it has been posted here:
fastai/nbdev#1404

@ronfan ronfan closed this as completed Apr 18, 2024
@cscheid cscheid closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants