-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto preview broken (command not found) when using bundled Quarto and Pyenv #517
Comments
Could it be related to latest addition by @jmcphers ? This is quite recent and would require very latest version of extension, and we may need to build a new one if not already. |
Version 114 of the extension has change #503, and Positron bundles version 114. If I'm reading the code correctly, though, this would be a problem on any system that doesn't have quarto on the path. That includes e.g. quarto when found only inside an RStudio installation. |
I spent some time looking into this. It looks like the Quarto extension does indeed try to add quarto/apps/vscode/src/main.ts Lines 71 to 75 in 8ec3fc8
The Terminal: Show Environment Contributions command shows that this works as it's supposed to: And in fact, I can't repro this problem at all with the latest build of Positron; quarto does get added to the path and it works fine. |
I just tried with the latest build of Positron (2024.08.0-77 on Windows and it doesn't find Quarto.
|
@jonvanausdeln what does the Terminal: Show Environment Contributions command show for you? |
side note - I did reboot after all the uninstall/install |
Thank you for checking! This is what I see on macOS: So this is working Sometimes but Not Always. Cool. Related upstream, maybe? microsoft/vscode#188235 @testlabauto Could you grab some terminal trace logs and send them to me? Here's how: https://github.com/microsoft/vscode/wiki/Terminal-Issues#enabling-trace-logging |
@jonvanausdeln are you using Pyenv by any chance? and can you show what your I noticed that @testlabauto's |
@jmcphers , yes I am using pyenv Also, here is the
|
It looks to me like the problem is that quarto is added (we confirmed that by looking at your Environment Contributions)... but Pyenv removes it when the Terminal starts (it organizes the Some possible routes forward:
|
It turns out, this PATH addition was being overridden by |
I have a Positron smoke test that opens a sample RMD file and then attempts to preview it with cmd+shift+k. It is failing to find the bundled Quarto installation and in the Positron terminal I am seeing:
Discussing this with @jmcphers, he has noted that we need to adjust the PATH in the created Quarto Preview terminal so that the terminal can access the Quarto installation even if it is not on the PATH.
The text was updated successfully, but these errors were encountered: