Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting for .ts and .json files in apps/vscode/ #590

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

juliasilge
Copy link
Collaborator

This PR updates the formatting on .ts and .json to use the workspace settings, so we don't continue to have so much extraneous whitespace change in PRs like #589.

@DavisVaughan
Copy link
Collaborator

eep let us merge in the existing ones first!

@juliasilge
Copy link
Collaborator Author

Wait for #577 to be merged, before merging this one (I think #585 will be easy to resolve)

@DavisVaughan
Copy link
Collaborator

DavisVaughan commented Oct 29, 2024

We should also see if we can set these

    "files.insertFinalNewline": true,
    "files.trimFinalNewlines": true,
    "files.trimTrailingWhitespace": true,

at the very least, trim trailing whitespace would be nice - but i dont know how to reapply it over the whole folder

@juliasilge
Copy link
Collaborator Author

This one is now ready for a review and to be merged. Here's to making things less painful moving forward! 🙌

@juliasilge juliasilge requested a review from cscheid October 30, 2024 18:02
Copy link
Contributor

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@juliasilge juliasilge merged commit 5919680 into main Nov 1, 2024
1 check passed
@juliasilge juliasilge deleted the update-vscode-ext-formatting branch November 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants