sqruff.toml support

[musjj]

TOML config support would be nice to have, especially in a Rust project.

[benfdking]

Hey @musjj,

Thanks for the issue; I'm just trying to understand your request exactly. You can already configure sqruff with a a .sqruff file? Is there any particular difference you mean?

[musjj]

.sqruff currently uses the ini format (particularly, sqlfluff's special flavor of it).

[sqlfluff]
templater = jinja

[sqlfluff:indentation]
indented_joins = False

It would be nice if we can just use toml, which is probably more familiar to Rust users:

[sqlfluff]
templater = "jinja"

[sqlfluff.indentation]
indented_joins = false

[benfdking]

Hey @musjj,

Thanks for clarifying! I think getting to a more robust standard is worthwhile! The toml standard is better defined, and it will be easier to build compatible tooling, I would love to give people a schema validation file!

The problem with the above is slightly more complicated as the real hurdle is unpacking the configuration code to do the above well. So, we would likely focus on that first.

I worry slightly about the audience; our users are generally "data people," and I think the most familiar configuration definition we are used to is yaml.

Ultimately, though, I think overall a strongly typed (with JSON schema) toml might be the best long-term outcome.

[quassy]

Adding to this, it would be great if pyproject.toml was also supported. This would make transition from sqlfluff for Python-first projects much easier.

First time I tried sqruff I assumed because it's supposed to be compatible with sqlfluff rules that it would pick up the config and then thought sqruff was not working correctly/at all with a custom config. Only later I saw that apparently it would only pick up on .sqlfluff.

[lu-zero]

Having a Config struct that can be used with serde probably could make dealing with toml and yaml formatting relatively painless might not be too hard. Or at least much easier than what you currently have to deal with the quirks of the sqlfluff format.