Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add start-of-string anchor to regex patterns in lexer #940

Merged
merged 1 commit into from
Nov 8, 2024
Merged

refactor: add start-of-string anchor to regex patterns in lexer #940

merged 1 commit into from
Nov 8, 2024

Conversation

gvozdvmozgu
Copy link
Collaborator

@gvozdvmozgu gvozdvmozgu commented Nov 8, 2024 •
edited
Loading

fix #939

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Benchmark for 7b87380

Click to view benchmark
Test Base PR %
DepthMap::from_parent 41.5±0.48µs 40.4±1.00µs -2.65%
fix_complex_query 11.9±0.16ms 12.0±0.14ms +0.84%
parse_complex_query 2.8±0.02µs 2.8±0.05µs 0.00%
parse_expression_recursion 5.0±0.05µs 5.0±0.06µs 0.00%
parse_simple_query 818.5±12.23ns 853.7±23.07ns +4.30%

@gvozdvmozgu gvozdvmozgu requested a review from benfdking November 8, 2024 19:58
@benfdking benfdking enabled auto-merge November 8, 2024 23:16
@benfdking benfdking added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit 7da522c Nov 8, 2024
15 checks passed
@benfdking benfdking deleted the fix/lexer-regex-start-anchor branch November 8, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfdking benfdking benfdking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Performance degrades exponentially as the number of lines in a file increases
2 participants
@gvozdvmozgu @benfdking