Skip to content

Session#verify is misleading #939

@philipwhiuk

Description

@philipwhiuk

From the name verify you could be excused from thinking that all it does is a form of validation.

Indeed the majority of the message does do this, checking sequence numbers and so-on.

But the last line is to call fromCallback

fromCallback(msgType, msg, sessionID);

This radically expands the verify method to actually being the point of entry to the Application for FIX traffic.

I can see two options

  1. Rename verify to verifyAndProcessMessage
  2. Move the fromCallback call outside verify and restructuring callers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions