Skip to content

Commit a6a7df0

Browse files
committed
Revert "Replace b.Loop() with correct benchmark loop syntax in Go (#876)"
This reverts commit 0a483a5.
1 parent ac3af82 commit a6a7df0

File tree

8 files changed

+10
-10
lines changed

8 files changed

+10
-10
lines changed

blogrenderer/renderer_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ func BenchmarkRender(b *testing.B) {
6363
b.Fatal(err)
6464
}
6565

66-
for i := 0; i < b.N; i++ {
66+
for b.Loop() {
6767
postRenderer.Render(io.Discard, aPost)
6868
}
6969
}

concurrency.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ func BenchmarkCheckWebsites(b *testing.B) {
9393
urls[i] = "a url"
9494
}
9595

96-
for i := 0; i < b.N; i++ {
96+
for b.Loop() {
9797
CheckWebsites(slowStubWebsiteChecker, urls)
9898
}
9999
}

concurrency/v1/check_websites_benchmark_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func BenchmarkCheckWebsites(b *testing.B) {
1616
urls[i] = "a url"
1717
}
1818

19-
for i := 0; i < b.N; i++ {
19+
for b.Loop() {
2020
CheckWebsites(slowStubWebsiteChecker, urls)
2121
}
2222
}

concurrency/v2/check_websites_benchmark_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func BenchmarkCheckWebsites(b *testing.B) {
1616
urls[i] = "a url"
1717
}
1818

19-
for i := 0; i < b.N; i++ {
19+
for b.Loop() {
2020
CheckWebsites(slowStubWebsiteChecker, urls)
2121
}
2222
}

concurrency/v3/check_websites_benchmark_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ func BenchmarkCheckWebsites(b *testing.B) {
1616
urls[i] = "a url"
1717
}
1818

19-
for i := 0; i < b.N; i++ {
19+
for b.Loop() {
2020
CheckWebsites(slowStubWebsiteChecker, urls)
2121
}
2222
}

for/vx/repeat_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ func TestRepeat(t *testing.T) {
1212
}
1313

1414
func BenchmarkRepeat(b *testing.B) {
15-
for i := 0; i < b.N; i++ {
15+
for b.Loop() {
1616
Repeat("a")
1717
}
1818
}

html-templates.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ func BenchmarkRender(b *testing.B) {
557557
}
558558
)
559559

560-
for i := 0; i < b.N; i++ {
560+
for b.Loop() {
561561
blogrenderer.Render(io.Discard, aPost)
562562
}
563563
}
@@ -645,7 +645,7 @@ func BenchmarkRender(b *testing.B) {
645645
b.Fatal(err)
646646
}
647647

648-
for i := 0; i < b.N; i++ {
648+
for b.Loop() {
649649
postRenderer.Render(io.Discard, aPost)
650650
}
651651
}

iteration.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ Writing [benchmarks](https://golang.org/pkg/testing/#hdr-Benchmarks) in Go is an
9797

9898
```go
9999
func BenchmarkRepeat(b *testing.B) {
100-
for i := 0; i < b.N; i++ {
100+
for b.Loop() {
101101
Repeat("a")
102102
}
103103
}
@@ -130,7 +130,7 @@ Only the body of the loop is timed; it automatically excludes setup and cleanup
130130
```go
131131
func Benchmark(b *testing.B) {
132132
//... setup ...
133-
for i := 0; i < b.N; i++ {
133+
for b.Loop() {
134134
//... code to measure ...
135135
}
136136
//... cleanup ...

0 commit comments

Comments
 (0)