Skip to content

Commit da758b8

Browse files
committed
Cleanup dataset operation
1 parent 549573b commit da758b8

File tree

1 file changed

+26
-29
lines changed

1 file changed

+26
-29
lines changed

quotientai/resources/datasets.py

Lines changed: 26 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def list(self) -> List[Dataset]:
137137

138138
return datasets
139139

140-
def get(self, id: str, include_rows: bool = False) -> Dataset:
140+
def get(self, id: str) -> Dataset:
141141
"""
142142
Get a dataset by ID.
143143
@@ -153,35 +153,30 @@ def get(self, id: str, include_rows: bool = False) -> Dataset:
153153
Dataset
154154
The dataset with the given ID.
155155
"""
156-
if include_rows:
157-
response = self._client._get(f"/datasets/{id}?include_rows=true")
158-
else:
159-
response = self._client._get(f"/datasets/{id}")
156+
response = self._client._get(f"/datasets/{id}")
160157

161-
response = response.json()
162158
response["created_at"] = datetime.fromisoformat(response["created_at"])
163159
response["updated_at"] = datetime.fromisoformat(response["updated_at"])
164160

165-
if include_rows:
166-
rows = []
167-
for row in response["rows"]:
168-
row["created_at"] = datetime.fromisoformat(row["created_at"])
169-
row["updated_at"] = datetime.fromisoformat(row["updated_at"])
170-
rows.append(DatasetRow(
171-
id=row["id"],
172-
input=row["input"],
173-
context=row["context"],
174-
expected=row["expected"],
175-
metadata=DatasetRowMetadata(
176-
annotation=row["annotation"],
177-
annotation_note=row["annotation_note"],
178-
),
179-
created_at=row["created_at"],
180-
created_by=row["created_by"],
181-
updated_at=row["updated_at"],
182-
))
161+
rows = []
162+
for row in response["dataset_rows"]:
163+
row["created_at"] = datetime.fromisoformat(row["created_at"])
164+
row["updated_at"] = datetime.fromisoformat(row["updated_at"])
165+
rows.append(DatasetRow(
166+
id=row["dataset_row_id"],
167+
input=row["input"],
168+
context=row["context"],
169+
expected=row["expected"],
170+
metadata=DatasetRowMetadata(
171+
annotation=row["annotation"],
172+
annotation_note=row["annotation_note"],
173+
),
174+
created_at=row["created_at"],
175+
created_by=row["created_by"],
176+
updated_at=row["updated_at"],
177+
))
183178

184-
response["rows"] = rows
179+
response["rows"] = rows
185180

186181
dataset = Dataset(
187182
id=response["id"],
@@ -317,7 +312,7 @@ def append(
317312
) -> Dataset:
318313
"""
319314
Append rows to an existing dataset.
320-
315+
321316
Parameters
322317
----------
323318
dataset : Dataset
@@ -342,8 +337,10 @@ def append(
342337
input=row_response["input"],
343338
context=row_response["context"],
344339
expected=row_response["expected"],
345-
annotation=row_response["annotation"],
346-
annotation_note=row_response["annotation_note"],
340+
metadata=DatasetRowMetadata(
341+
annotation=row_response["annotation"],
342+
annotation_note=row_response["annotation_note"],
343+
),
347344
created_at=row_response["created_at"],
348345
created_by=row_response["created_by"],
349346
updated_at=row_response["updated_at"],
@@ -357,7 +354,7 @@ def append(
357354
created_at=dataset.created_at,
358355
updated_at=dataset.updated_at,
359356
created_by=dataset.created_by,
360-
rows=row_responses,
357+
rows=dataset.rows + row_responses,
361358
)
362359
return dataset
363360

0 commit comments

Comments
 (0)