Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Tabs do not have enough contrast while using certain themes #1058

Open
s-daveb opened this issue May 6, 2024 · 0 comments
Open

Custom Tabs do not have enough contrast while using certain themes #1058

s-daveb opened this issue May 6, 2024 · 0 comments

Comments

@s-daveb
Copy link
Contributor

s-daveb commented May 6, 2024

Hello!

Since making the switch to Neovim, I've been thoroughly enjoying VimR over MacVim!

One nagging issue I've had, however, is that the theme I enjoy (everforest) uses a very light color for visual select. Upon switching to VimR, I noticed the custom tabs were much lighter than the built-in neovim tabs.

Screenshot 2024-05-06 at 2 58 17 PM

After looking through issues I discovered that VimR is using selection text color to theme its tabs, rather than the colorscheme's TablineSel highlight group, which was what I expected as a long-time vimmer.

There's probably two ways to solve this:

  • Add logic to the Tab view so that for light colors, a darker text is selected
  • Match Vim's native behavior and use the tab colors defined in the colorscheme. (The theme authors probably chose contrasting colors. )

As an experiment, and as someone who hasn't worked with a lot of Swift, I decided to try solution 2, not wanting to try to add code to predict good text contrast for every possible vim color scheme.

I will submit a PR in addition to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant