fix buglet in str.{Date,POSIXt}(<length 0>, give.attr=FALSE)

git-svn-id: https://svn.r-project.org/R/trunk@89075 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: maechler

doc/NEWS.Rd

@@ -389,6 +389,18 @@
       \item \code{diff(m, lag, dif)} for matrix \code{m} now still returns
       matrices, also when \code{lag * dif > nrow(m)} (\PR{18972}, thanks to
       \I{Mikael Jagan}).
+
+      \item \code{str(x, give.attr=FALSE)} no longer shows attributes when
+      \code{x} is a zero length \code{"Date"} or \code{"POSIXt"} object.
+    }
+  }
+}
+
+\section{\Rlogo CHANGES IN R 4.5.2 patched}{
+
+  \subsection{BUG FIXES}{
+    \itemize{
+      \item .
     }
   }
 }

src/library/utils/R/str.R

@@ -48,7 +48,7 @@ str.Date <- str.POSIXt <- function(object, ...) {
     cl <- oldClass(object)
     ## be careful to be fast for large object:
     n <- length(object) # FIXME, could be NA
-    if(n == 0L) return(str.default(object))
+    if(n == 0L) return(str.default(object, ...))
     if(n > 1000L) object <- object[seq_len(1000L)]
 
     give.length <- TRUE ## default
@@ -555,9 +555,8 @@ str.default <-
 		format.fun <- deParse
 	    } else {
 		if(mod == "...") { # DOTSXP
-		    format.fun <- function(x) { # use le := length(x)
-			le <- length(x) ## for testing <<<<< FIXME DROP!! <<<<<<<<<<
-			hasNm <- nzchar(nm <- names(x) %||% rep.int("", le))
+		    format.fun <- function(x) {
+			hasNm <- nzchar(nm <- names(x) %||% rep.int("", length(x)))
 			nm[hasNm] <- paste0(nm[hasNm], "=")
 			paste0("(", paste(paste0(nm,"*"), collapse=", "),
 			       ")")

tests/reg-tests-1e.R

@@ -2385,7 +2385,15 @@ str(L, give.attr=FALSE) # now  0 x 1  matrices
   vapply(L, \(.) identical(.$f0, .$f), NA) # where all FALSE; now not all TRUE
 stopifnot( print(
   vapply(L, \(.) identical(.$f0 - .$f0, .$f), NA) ) )
-## where all FALSE : diff(fnm, 2,5) was not a matrix
+## were all FALSE : diff(fnm, 2,5) was not a matrix
+
+
+## str.{Date,POSIXt}(<length 0>, give.attr=FALSE) - now works
+chk0 <- function(x) identical(capture.output(str(x,  give.attr = FALSE)),
+                              capture.output(str(`attr<-`(x, "foobar", NULL))))
+stopifnot(chk0(structure(.Date   (numeric()), foobar = list(Dt = "A"))),
+          chk0(structure(.POSIXct(numeric()), foobar = list(ct = "C"))))
+## in R <= 4.5.2, give.attr=FALSE was not obeyed for 0-length "Date" / "POSIXt"