prettyNum(*, zero.print = {>=1-char}, replace.zero) bug fix

git-svn-id: https://svn.r-project.org/R/trunk@88238 00db46b3-68df-0310-9c12-caf00c1e9a41

Author: maechler

doc/NEWS.Rd

@@ -116,7 +116,7 @@
       %% including tkrplot, loon and tcltk2
     }
   }
-  
+
   \subsection{BUG FIXES}{
     \itemize{
       \item Java detection in \code{javareconf} could not detect
@@ -142,6 +142,11 @@
 
       \item \code{signif(1.**e308, digits)} no longer truncates unnecessarily
       (but still to prevent overflow to \code{Inf}), fixing \PR{18889}.
+
+      \code{pbeta(x, a,b, ..)} for very large \code{a,b} no longer returns
+      \code{NaN} but the correct values (0 or 1, or their logs for \code{log.p = TRUE}).
+      This improves Mathlib's C level \code{bratio()} and hence also
+      \code{pnbinom()}, etc..
     }
   }
 }

src/library/base/R/format.R

@@ -1,7 +1,7 @@
 #  File src/library/base/R/format.R
 #  Part of the R package, https://www.R-project.org
 #
-#  Copyright (C) 1995-2024 The R Core Team
+#  Copyright (C) 1995-2025 The R Core Team
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -73,7 +73,7 @@ format.default <-
 			     decimal.mark = decimal.mark, input.d.mark = decimal.mark,
 			     zero.print = zero.print, drop0trailing = drop0trailing,
 			     is.cmplx = is.complex(x),
-			     preserve.width = if (trim) "individual" else "common"),
+			     preserve.width = if (trim) "individual" else "common", ...),
 	       ## all others (for now):
 	       stop(gettextf("Found no format() method for class \"%s\"",
 			     class(x)), domain = NA))
@@ -338,7 +338,7 @@ prettyNum <-
 		    big.mark=big.mark, big.interval=big.interval,
 		    small.mark=small.mark, small.interval=small.interval,
 		    decimal.mark=decimal.mark, zero.print=zero.print,
-		    drop0trailing=drop0trailing, ...)
+		    drop0trailing=drop0trailing, replace.zero=replace.zero, ...)
     }
     ## be fast in trivial case, when all options have their default, or "match"
     nMark <- big.mark == "" && small.mark == "" && (notChar || decimal.mark == input.d.mark)

tests/reg-tests-1e.R

@@ -1956,6 +1956,18 @@ stopifnot(all.equal(1.1e308,  signif(1.06e308,   2)),
           all.equal(1.01e308, signif(1.0055e308, 3)))
 
 
+## prettyNum(.., zero.print = <2-or-more-char>, replace.zero=TRUE) --
+zp <- "--"; num <- -1:2
+assertWarnV(
+p1 <- prettyNum(num, zero.print = zp) )
+p2 <- prettyNum(num, zero.print = zp, replace.zero=TRUE) # was Error (converted from warning)
+stopifnot(identical(p1[2], substr(zp,1,1)),
+          identical(p2[2], zp),
+          identical(p1[num != 0], p2[num != 0]),
+          identical(p2, local({ p <- as.character(num); p[p == 0] <- zp; p })))
+## p2 gave warning too, and was the same as p1, erronously in  R <= 4.5.0
+
+
 
 ## keep at end
 rbind(last =  proc.time() - .pt,