diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md deleted file mode 100644 index 45b7731c..00000000 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ /dev/null @@ -1,40 +0,0 @@ - -### Summary - - - -Fixes # - -*Lorem ipsum dolor sit amet, consectetur adipiscing.* - -### List of changes proposed in this PR (pull-request) - - - -* *Lorem ipsum dolor sit amet, consectetur adipiscing.* -* *Lorem ipsum dolor sit amet, consectetur adipiscing.* - -### Some housekeeping checks - -- [ ] If you have added a new chapter(s)/section(s) to the guide, have you updated the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? -- If you have added a new chapter(s) to the guide: - - [ ] Have you listed it (them) in the `_quarto.yml`? - - [ ] Are the filename(s) for the new chapter(s) in lower case? - - [ ] Are the words in the filename(s) for the new chapter(s) separated by `_` (if required)? - -### What should a reviewer concentrate their feedback on? - - - -- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* -- [ ] Everything looks ok? - -### Acknowledging contributors - - - -- [ ] All contributors to this pull request are already named in the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-) in the README file. -- [ ] The following people should be added to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-) in the README file: -- [ ] Use the [How to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md) to add new contributor(s) using the [All Contributors](https://allcontributors.org/) Bot. diff --git a/.github/PULL_REQUEST_TEMPLATE/add_new_chapter.md b/.github/PULL_REQUEST_TEMPLATE/add_new_chapter.md new file mode 100644 index 00000000..c7629bbe --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/add_new_chapter.md @@ -0,0 +1,40 @@ + +### Summary + + + +*Lorem ipsum dolor sit amet, consectetur adipiscing.* + + + +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* + + + +Fixes # + +### Checklist for adding a new chapter or chapters + + + +- [ ] Have you updated the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? +- [ ] Have you updated the `chapters` field of `_quarto.yml`? This determines the chapter ordering. +- [ ] Have you named the new `.qmd` files using lower case, with words separated by `_` if required? + +### What should a reviewer concentrate their feedback on? + + + +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* +- [ ] Everything looks ok? + +### Acknowledging contributors + +List any contributions that need adding to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-). Common contributions are `content` (adding to the guide), `doc` (e.g. README, wiki), `infra` (e.g. GitHub action), and `maintenance` (e.g. fixing links). See the full key to [Contribution Types](https://allcontributors.org/docs/en/emoji-key). + +- [ ] Please add @ for . Please add @ for , . +- [ ] **For reviewers**: All relevant contributions have been added, including reviewers, mentors, contributors to the ideas/planning. See [how to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md). \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md b/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md new file mode 100644 index 00000000..1b5ab7a6 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md @@ -0,0 +1,32 @@ + +### Summary + + + +*Lorem ipsum dolor sit amet, consectetur adipiscing.* + + + +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* + + + +Fixes # + +### What should a reviewer concentrate their feedback on? + + + +- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* +- [ ] Everything looks ok? + +### Acknowledging contributors + +List any contributions that need adding to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-). Common contributions are `content` (adding to the guide), `doc` (e.g. README, wiki), `infra` (e.g. GitHub action), and `maintenance` (e.g. fixing links). See the full key to [Contribution Types](https://allcontributors.org/docs/en/emoji-key). + +- [ ] Please add @ for . Please add @ for , . +- [ ] **For reviewers**: All relevant contributions have been added, including reviewers, mentors, contributors to the ideas/planning. See [how to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md). \ No newline at end of file