From aeaf5eb5ae749c2d3da665dd81d9fd8fcde03123 Mon Sep 17 00:00:00 2001 From: Heather Turner Date: Wed, 11 Dec 2024 10:06:56 +0000 Subject: [PATCH] revert to single PR template --- .../general_pull_request.md | 32 ------------------- ...ew_chapter.md => pull_request_template.md} | 3 +- 2 files changed, 2 insertions(+), 33 deletions(-) delete mode 100644 .github/PULL_REQUEST_TEMPLATE/general_pull_request.md rename .github/{PULL_REQUEST_TEMPLATE/add_new_chapter.md => pull_request_template.md} (94%) diff --git a/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md b/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md deleted file mode 100644 index 1b5ab7a..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/general_pull_request.md +++ /dev/null @@ -1,32 +0,0 @@ - -### Summary - - - -*Lorem ipsum dolor sit amet, consectetur adipiscing.* - - - -- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* -- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* - - - -Fixes # - -### What should a reviewer concentrate their feedback on? - - - -- [ ] *Lorem ipsum dolor sit amet, consectetur adipiscing.* -- [ ] Everything looks ok? - -### Acknowledging contributors - -List any contributions that need adding to the [table of contributors](https://github.com/r-devel/rdevguide/blob/main/README.md#contributors-). Common contributions are `content` (adding to the guide), `doc` (e.g. README, wiki), `infra` (e.g. GitHub action), and `maintenance` (e.g. fixing links). See the full key to [Contribution Types](https://allcontributors.org/docs/en/emoji-key). - -- [ ] Please add @ for . Please add @ for , . -- [ ] **For reviewers**: All relevant contributions have been added, including reviewers, mentors, contributors to the ideas/planning. See [how to acknowledge contributors](https://github.com/r-devel/rdevguide/blob/main/HOWTO-acknowledge-contributors.md). \ No newline at end of file diff --git a/.github/PULL_REQUEST_TEMPLATE/add_new_chapter.md b/.github/pull_request_template.md similarity index 94% rename from .github/PULL_REQUEST_TEMPLATE/add_new_chapter.md rename to .github/pull_request_template.md index c7629bb..d9571c1 100644 --- a/.github/PULL_REQUEST_TEMPLATE/add_new_chapter.md +++ b/.github/pull_request_template.md @@ -19,7 +19,8 @@ Fixes # ### Checklist for adding a new chapter or chapters - + - [ ] Have you updated the [Quick start to the guide](https://contributor.r-project.org/rdevguide/introduction.html#quick-start-to-the-guide) accordingly? - [ ] Have you updated the `chapters` field of `_quarto.yml`? This determines the chapter ordering.