Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checking a package in a subdirectory #5

Closed
amoeba opened this issue Aug 3, 2024 · 9 comments · Fixed by #6
Closed

Add support for checking a package in a subdirectory #5

amoeba opened this issue Aug 3, 2024 · 9 comments · Fixed by #6

Comments

@amoeba
Copy link
Contributor

amoeba commented Aug 3, 2024

Hello! I'm interested in running recheck on a package that lives in a subdirectory of a repo and I think there's not currently a way to do this. Would you be interested in seeing a PR adding support for that?

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

Hey @jeroen, just wanted to check in to see if the change in #6 would be of interest and if you might have some time in the future to have a look. Thanks in advance.

@jeroen jeroen closed this as completed in #6 Aug 21, 2024
@jeroen
Copy link
Member

jeroen commented Aug 21, 2024

OK. I think we also need to update the readme for this parameter?

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

Yeah that would be good. I'll send a follow-on PR to update the README.

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

Oh, looks like you've already done that. Thank you!

@jeroen
Copy link
Member

jeroen commented Aug 21, 2024 via email

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

Sure, I'll test now.

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

I ran it on my fork and it looks like it didn't set the source directory, see the raw log. Looking at it now.

@jeroen
Copy link
Member

jeroen commented Aug 21, 2024

I think this may fix it: 6434f10

@amoeba
Copy link
Contributor Author

amoeba commented Aug 21, 2024

I think that did it. The docs make the two approaches sound equivalent at least for this use case. Thanks for fixing and for merging the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants