Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file for file name input #43

Open
1 of 14 tasks
GegznaV opened this issue Jul 27, 2021 · 2 comments
Open
1 of 14 tasks

Use file for file name input #43

GegznaV opened this issue Jul 27, 2021 · 2 comments

Comments

@GegznaV
Copy link
Member

GegznaV commented Jul 27, 2021

In read_*() functions, we currently use file, files, filename or con to indicate the path to file or connection. We should use file consistently. Update argument name in these functions:

  • read_asc_Andor
  • read_asc_PerkinElmer
  • read_ini
  • read_txt_Horiba
  • read_txt_Horiba_t
  • read_txt_Horiba_xy
  • read_zip_Renishaw
  • read_txt_Renishaw
  • read_txt_Shimadzu
  • read_dat_Witec
  • read_txt_Witec
  • read_txt_Witec_Graph
  • read_txt_Witec_TrueMatch

NOTE: some functions use specific argument names like filex. Please, mention functions like this by commenting on this issue. We should decide on the names of these arguments separately.


@GegznaV
Copy link
Member Author

GegznaV commented Jul 27, 2021

GegznaV added a commit that referenced this issue Aug 6, 2021
GegznaV added a commit that referenced this issue Aug 10, 2021
GegznaV added a commit that referenced this issue Aug 10, 2021
GegznaV added a commit that referenced this issue Aug 10, 2021
@GegznaV
Copy link
Member Author

GegznaV commented Aug 16, 2021

This issue is ready to be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant