Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more consistent signature for methods of as.hyperSpec() #16

Open
GegznaV opened this issue Jul 27, 2021 · 0 comments
Open

Use more consistent signature for methods of as.hyperSpec() #16

GegznaV opened this issue Jul 27, 2021 · 0 comments

Comments

@GegznaV
Copy link
Member

GegznaV commented Jul 27, 2021

Currently, each method of as.hyperSpec() uses its own order, default values, and number of arguments:

.as.hyperSpec.matrix <- function(X, wl = NULL, ...)

.as.hyperSpec.data.frame <- function(X, spc = NULL, wl = NULL, labels = attr(X, "labels"), ...)

.as.hyperSpec.hyperSpec <- function(X)

This makes it more difficult to use in other functions as each case should be addressed separately.
My suggestions would be to:

May also be related:


This issue originally was:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant