Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fitraster() → raster_fit(), makeraster → raster_make #47

Open
Tracked by #38
GegznaV opened this issue Aug 11, 2021 · 1 comment · Fixed by #74
Open
Tracked by #38

Rename fitraster() → raster_fit(), makeraster → raster_make #47

GegznaV opened this issue Aug 11, 2021 · 1 comment · Fixed by #74
Labels
Status: under consideration ❗ Topic: rename ♻️
Milestone
1.0 CRAN submission

Comments

@GegznaV
Copy link
Member

GegznaV commented Aug 11, 2021

Current name Rename to Alternative
fitraster → fit_raster raster_fit (to follow the same name pattern)
makeraster → make_raster raster_make (to follow the same name pattern)

The documentation says:

makeraster() fits the data to the specified raster.

So I'm a bit confused. I do not fully understand what these functions do and what is the purpose of them so maybe some other names would be a better fit? @cbeleites
@GegznaV GegznaV added this to the 1.0 CRAN submission milestone Aug 11, 2021
@GegznaV GegznaV mentioned this issue Aug 11, 2021
Open
13 tasks
GegznaV added a commit that referenced this issue Dec 14, 2021
@GegznaV
Update NEWS.md
1a77c1a 
#47
@GegznaV GegznaV mentioned this issue Dec 14, 2021
Merged
@GegznaV GegznaV reopened this Dec 14, 2021
@GegznaV
Copy link
Member Author

GegznaV commented Dec 14, 2021

I do not close this yet as more appropriate names might be considered before the 1.0.0 release.

@GegznaV GegznaV changed the title Rename fitraster() → fit_raster() |raster_fit() etc. Rename fitraster() → raster_fit(), makeraster → raster_make Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: under consideration ❗ Topic: rename ♻️
Projects
None yet
Milestone
1.0 CRAN submission
Development

Successfully merging a pull request may close this issue.

Feature 38/rename functions (47) r-hyperspec/hyperSpec
1 participant
@GegznaV