Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as_integers and as_doubles should understand logical inputs #297

Open
vspinu opened this issue Nov 2, 2022 · 0 comments
Open

as_integers and as_doubles should understand logical inputs #297

vspinu opened this issue Nov 2, 2022 · 0 comments

Comments

@vspinu
Copy link
Contributor

vspinu commented Nov 2, 2022

Arguably logicals are also "integer like", but the main use case is the all-NA input vectors. When a user enters xyz(arg = NA) and arg is intended to be an integer the cpp level conversion with as_integers fails.

For this reason as_integers is still incomplete because we still need a custom wrapper around as_integer for logicals internally.

Would be really great if it could be done as part of #265 (cc @DavisVaughan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant