Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorization header not matching AWS examples #627

Closed
billsanto opened this issue Jan 6, 2025 · 4 comments
Closed

Authorization header not matching AWS examples #627

billsanto opened this issue Jan 6, 2025 · 4 comments
Milestone

Comments

@billsanto
Copy link

On line 189 it shows a comma added between the first two fields.

Algorithm, ",",

In online examples on AWS documents, it shows a space separating the first two fields, whereas commas are used between the subsequent fields. Similarly, this online tool shows the same pattern.

@hadley
Copy link
Member

hadley commented Jan 6, 2025

Thanks! Is this causing auth to fail for you?

@billsanto
Copy link
Author

I haven't tried directly against AWS. We have a proxy in front of Bedrock, and in the process of troubleshooting with them they pointed out the header was not conforming to the expected format. Maybe AWS is more forgiving in how it parses the header, but I don't know. That team updated the dev proxy for me to test, so we are past that as it now accepts the comma as is, but we are now at the stage of struggling to match signatures with a hacked provider-bedrock using the Invoke API, which is a separate issue.

I have successfully tested our proxy in R with httr and aws.signature when I construct the headers and signature. But when I'm using Ellmer, that is not an option.

@hadley
Copy link
Member

hadley commented Jan 6, 2025

I'm hoping to implement #435 soon, which might also help.

@hadley hadley added this to the v1.1.0 milestone Jan 8, 2025
@hadley
Copy link
Member

hadley commented Jan 8, 2025

I'll fix momentarily. It's weird that AWS lets this work at all. Thanks for reporting!

@hadley hadley closed this as completed in 4050f9b Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants