Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:npm-deps compat #176

Closed
lgrapenthin opened this issue Sep 4, 2017 · 4 comments
Closed

:npm-deps compat #176

lgrapenthin opened this issue Sep 4, 2017 · 4 comments

Comments

@lgrapenthin
Copy link

lgrapenthin commented Sep 4, 2017

If I require per :npm-deps Compiler feater, is there already a way to use Sablono? Right now Sablono says No such namespace: cljsjs.react, could not locate cljsjs/react.cljs, cljsjs/react.cljc, or JavaScript source providing "cljsjs.react", in resources/public/cljs/out/sablono/interpreter.cljc

@r0man
Copy link
Owner

r0man commented Sep 4, 2017

@lgrapenthin I haven't looked at the new :npm-deps stuff yet, and quite busy at the moment and don't have time to look into this now. @Deraen opened a PR recently but I'm not sure of it's state.
#175

@Deraen
Copy link

Deraen commented Sep 4, 2017

I will try to fix the tests with the changes soon. Releasing the support will require updating also Om, Rum and Devcards at the same time as Sablono.

Btw. :npm-deps is not a correct name for the new features. "Node modules support" or "Module processing" are better names. I'll try to update ClojureScript docs before we update all the packages.

@r0man
Copy link
Owner

r0man commented Sep 4, 2017

@Deraen ok, thanks for the update and the work on the PR.

@r0man
Copy link
Owner

r0man commented Jan 2, 2019

Closing this. Latest master requires React now, instead of using js/React

@r0man r0man closed this as completed Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants