Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Global-exports to require React and support node modules #175

Closed
wants to merge 1 commit into from

Conversation

Deraen
Copy link

@Deraen Deraen commented Aug 18, 2017

This is similar to reagent-project/reagent#306
https://github.com/reagent-project/reagent/blob/master/CHANGELOG.md#080-alpha1-2017-07-31

I'm opening PR's on other projects also:

It is possible further changes to ClojureScript will make this change (partially) unnecessary: https://dev.clojure.org/jira/browse/CLJS-2331

Build causes lots of warnings:

WARNING: No such namespace: react, could not locate react.cljs, react.cljc, or JavaScript source providing "react" at line 19 target/nodejs/out/devcards/util/edn_renderer.cljs
WARNING: Use of undeclared Var react/createElement at line 19 target/nodejs/out/devcards/util/edn_renderer.cljs

(some of the problems are caused by devcards and om probably)

And running tests on Node fails:

/home/juho/Source/sablono/target/nodejs/out/devcards/system.js:405
goog.inherits(ctor__19477__auto__,React.Component);
                                  ^

ReferenceError: React is not defined
    at /home/juho/Source/sablono/target/nodejs/out/devcards/system.js:405:35

@r0man
Copy link
Owner

r0man commented Jan 2, 2019

The lastest master requires now react, instead of using js/React. Thanks for the initial work on this.

@r0man r0man closed this Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants