Refactor example app

Author: ra1028

Examples/TheMovieDB/CustomHooks/UseFetchPage.swift

@@ -17,21 +17,10 @@ func useFetchPage<Response: Decodable>(
         results.current += response.results
     }
 
-    guard page.current == 0 else {
-        return (status: .success(results.current), fetch: fetch)
-    }
-
-    switch status {
-    case .pending:
-        return (status: .pending, fetch: fetch)
-
-    case .running:
-        return (status: .running, fetch: fetch)
+    let newStatus =
+        page.current == 0
+        ? status.map { _ in results.current }
+        : .success(results.current)
 
-    case .success:
-        return (status: .success(results.current), fetch: fetch)
-
-    case .failure(let error):
-        return (status: .failure(error), fetch: fetch)
-    }
+    return (status: newStatus, fetch: fetch)
 }

Examples/TheMovieDB/CustomHooks/UseNetworkImage.swift

@@ -14,11 +14,5 @@ func useNetworkImage(for path: String, size: NetworkImageSize) -> UIImage? {
             .receive(on: DispatchQueue.main)
     }
 
-    switch status {
-    case .success(let image):
-        return image
-
-    case .failure, .pending, .running:
-        return nil
-    }
+    return try? status.get() ?? nil
 }

Examples/TheMovieDB/TopRatedMoviesPage.swift

@@ -18,7 +18,7 @@ struct TopRatedMoviesPage: HookView {
                     failure(error, onReload: fetch)
 
                 case .pending, .running:
-                    ProgressView()
+                    loading
                 }
             }
             .navigationTitle("Top Rated Movies")
@@ -31,6 +31,10 @@ struct TopRatedMoviesPage: HookView {
         .onAppear(perform: fetch)
     }
 
+    var loading: some View {
+        ProgressView().frame(maxWidth: .infinity, maxHeight: .infinity)
+    }
+
     func failure(_ error: URLError, onReload: @escaping () -> Void) -> some View {
         VStack(spacing: 16) {
             Text("Failed to fetch movies")

Sources/Hooks/AsyncStatus.swift

@@ -25,14 +25,14 @@ public enum AsyncStatus<Success, Failure: Error> {
     /// If this instance represents a `pending` or a `running`, this returns nil.
     public var result: Result<Success, Failure>? {
         switch self {
-            case .pending, .running:
-                return nil
+        case .pending, .running:
+            return nil
 
-            case .success(let success):
-                return .success(success)
+        case .success(let success):
+            return .success(success)
 
-            case .failure(let error):
-                return .failure(error)
+        case .failure(let error):
+            return .failure(error)
         }
     }
 
@@ -55,17 +55,17 @@ public enum AsyncStatus<Success, Failure: Error> {
     /// - Returns: An `AsyncStatus` instance, either from the closure or the previous `.success`.
     public func flatMap<NewSuccess>(_ transform: (Success) -> AsyncStatus<NewSuccess, Failure>) -> AsyncStatus<NewSuccess, Failure> {
         switch self {
-            case .pending:
-                return .pending
+        case .pending:
+            return .pending
 
-            case .running:
-                return .running
+        case .running:
+            return .running
 
-            case .success(let value):
-                return transform(value)
+        case .success(let value):
+            return transform(value)
 
-            case .failure(let error):
-                return .failure(error)
+        case .failure(let error):
+            return .failure(error)
         }
     }
 
@@ -74,17 +74,17 @@ public enum AsyncStatus<Success, Failure: Error> {
     /// - Returns: An `AsyncStatus` instance, either from the closure or the previous `.failure`.
     public func flatMapError<NewFailure: Error>(_ transform: (Failure) -> AsyncStatus<Success, NewFailure>) -> AsyncStatus<Success, NewFailure> {
         switch self {
-            case .pending:
-                return .pending
+        case .pending:
+            return .pending
 
-            case .running:
-                return .running
+        case .running:
+            return .running
 
-            case .success(let value):
-                return .success(value)
+        case .success(let value):
+            return .success(value)
 
-            case .failure(let error):
-                return transform(error)
+        case .failure(let error):
+            return transform(error)
         }
     }
 
@@ -96,14 +96,14 @@ public enum AsyncStatus<Success, Failure: Error> {
     /// - Returns:  The success value, if the instance represents a success,If the status is `pending` or `running`, this returns nil. .
     public func get() throws -> Success? {
         switch self {
-            case .pending, .running:
-                return nil
+        case .pending, .running:
+            return nil
 
-            case .success(let value):
-                return value
+        case .success(let value):
+            return value
 
-            case .failure(let error):
-                throw error
+        case .failure(let error):
+            throw error
         }
     }
 }

Tests/AsyncStatusTests.swift

@@ -142,7 +142,7 @@ final class AsyncStatusTests: XCTestCase {
             nil,
             nil,
             100,
-            nil
+            nil,
         ]
 
         for (status, expected) in zip(statuses, expected) {