Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that peer node deals with unicode #10826

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lukebakken
Copy link
Collaborator

Follow-up to #10759
Related to #10194
Related to erlang/otp#8289

@lukebakken lukebakken self-assigned this Mar 21, 2024
[Why]
As shown in #10728, in an IPv6-only environment, `kernel` name
resolution must be configured through an inetrc file.

The temporary hidden node must be configured exactly like the main node
(and all nodes in the cluster in fact) to allow communication. Thus we
must pass the same inetrc file to that temporary hidden node. This
wasn’t the case before this patch.

[How]
We query the main node’s kernel to see if there is any inetrc file set
and we use the same on the temporary hidden node’s command line.

While here, extract the handling of the `proto_dist` module from the TLS
code. This parameter may be used outside of TLS like this IPv6-only
environment.

Fixes #10728.
@lukebakken lukebakken force-pushed the peer-disc-temporary-nodes-and-inetrc branch from 41d3c68 to 3fd96a0 Compare March 22, 2024 16:12
@michaelklishin michaelklishin force-pushed the peer-disc-temporary-nodes-and-inetrc branch from 3fd96a0 to 1bcfa47 Compare March 25, 2024 19:19
Base automatically changed from peer-disc-temporary-nodes-and-inetrc to main March 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants