Guard PipeReader.AdvanceTo on closed socket (#433)

moikot · web-flow · commit c75f4d52ee52 · 2025-09-05T14:42:27.000+02:00
Problem: A race during shutdown could call reader.AdvanceTo(buffer.Start, buffer.End) after the TCP socket is closed, risking exceptions that propagate via reader.CompleteAsync(caught) and noisy logs.
Change: In Connection.ProcessIncomingFrames, only call reader.AdvanceTo(...) when socket.Connected is true.
diff --git a/RabbitMQ.Stream.Client/Connection.cs b/RabbitMQ.Stream.Client/Connection.cs
@@ -189,7 +189,10 @@ private async Task ProcessIncomingFrames()
                         numFrames += 1;
                     }
 
-                    reader.AdvanceTo(buffer.Start, buffer.End);
+                    if (socket.Connected)
+                    {
+                        reader.AdvanceTo(buffer.Start, buffer.End);
+                    }
                 }
             }
             catch (OperationCanceledException e)

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,10 @@ private async Task ProcessIncomingFrames()`
`189`	`189`	`numFrames += 1;`
`190`	`190`	`}`
`191`	`191`
`192`		`- reader.AdvanceTo(buffer.Start, buffer.End);`
	`192`	`+ if (socket.Connected)`
	`193`	`+ {`
	`194`	`+ reader.AdvanceTo(buffer.Start, buffer.End);`
	`195`	`+ }`
`193`	`196`	`}`
`194`	`197`	`}`
`195`	`198`	`catch (OperationCanceledException e)`