Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: improve support for caret configuration #206

Open
LiberalArtist opened this issue Nov 29, 2020 · 7 comments
Open

Accessibility: improve support for caret configuration #206

LiberalArtist opened this issue Nov 29, 2020 · 7 comments

Comments

@LiberalArtist
Copy link
Contributor

This issue was first reported on the mailing list: some people find a blinking caret either an annoyance or an accessibility issue.

Robby’s 1c4e78e was a first step toward addressing this by creating a preference ('framework:caret-blink-disable?) to turn blinking off.

As noted, it would be nice to look at the system-level preference when available. The issue electron/electron#10668 seems to have some useful notes.

Beyond disabling blinking, it looks like all platforms support configuring the speed of caret blinking, and Windows and GTK seem to make the width and color of the caret configurable as well. Probably Racket should, too.

@rfindler
Copy link
Member

Since the code that actually does the drawing, etc., isn't in the framework, but is in wxme, the changes would have to be there for those parts.

@LiberalArtist
Copy link
Contributor Author

I haven't had a chance to test 1c4e78e yet, but IIUC making the change at the level of text:basic-mixin wouldn't affect, for example, text-field%. I haven't personally wanted to configure things this way, but it seems like users who want non-blinking want it in fields, too.

@rfindler
Copy link
Member

Yes, that's true. I put it in the framework because the preferences are accessible there. But you're right, it is better at the text% level.

@rfindler
Copy link
Member

Probably I should take it out before the release because of this!

@loafofpiecrust
Copy link

loafofpiecrust commented Mar 8, 2021

I'm not sure if this fits here, but I would love to be able to configure the type of caret used in an editor. In emacs, for example, the caret can be one of these types '(box underline hollow line). The most flexible option might be a method for caret drawing that I can override. GTK doesn't seem to support such a thing directly, but if it's possible that would be fantastic. I've been digging around a bit in the wxme code to figure this out, but there are virtually no comments in any of the code, making it very difficult to decipher.

@rfindler
Copy link
Member

rfindler commented Mar 8, 2021

@loafofpiecrust the editor is actually implemented completely at the Racket level, not using gtk's (or other platform's) editors. Changing the drawing of the insertion caret might be challenging as it is one of the parts of the text% that's got performance concerns currently.

@LiberalArtist
Copy link
Contributor Author

I'm not sure if this fits here, but I would love to be able to configure the type of caret used in an editor.

Related: racket/drracket#667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants