Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: evented track input #140

Merged
merged 52 commits into from
Dec 13, 2022
Merged

Conversation

hairmare
Copy link
Member

@hairmare hairmare commented Jan 1, 2022

Technically speaking this is the largest change in my 2022 songticker sprint. This change moves the current nowplaying main loop into it's own thread and spins up an additional (threaded) api server. The api server receives http requests and sends them on to the main loop via an event queue.

  • test most new functionality
  • test input observers
  • replace cherrypy framework bits with werkzeug
  • add moar docs
  • nonklangbeckeninput handling (is it's own issue: [input] nowplaying data for studio sources #173)
  • assert queue being used in tests/test_api.py
  • make --input-file (and reading it) optional/deactivatable

Fixes #38

@hairmare hairmare marked this pull request as draft January 1, 2022 11:43
@hairmare hairmare mentioned this pull request Jan 2, 2022
5 tasks
@hairmare hairmare marked this pull request as draft January 29, 2022 21:19
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@hairmare hairmare marked this pull request as draft February 14, 2022 20:13
tests/test_api.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@hairmare hairmare marked this pull request as ready for review August 21, 2022 10:50
@hairmare hairmare merged commit 8fc4215 into radiorabe:main Dec 13, 2022
@hairmare hairmare deleted the feat/evented-track-input branch December 13, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace now_playing XML input with modern replacements
1 participant