Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: tool to visualize Line-of-sight #1

Open
erwanp opened this issue Jun 14, 2021 · 0 comments
Open

Add: tool to visualize Line-of-sight #1

erwanp opened this issue Jun 14, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@erwanp
Copy link
Member

erwanp commented Jun 14, 2021

Idea : add a new tool with a Flowchart to show the line-of-sight being computed.

Would make the config function more obvious. :

Let's say we have :

def config(**slabs):
        return SerialSlabs(MergeSlabs(slabs['sPlasmaCO'], slabs['sPlasmaCO2']), slabs['sPostCO2'], slabs['sRoomCO2'])

We would get something like : :

image

(not sure about the eye 👁️ :) )

Clicking on the Spectra would return the current Spectrum conditions (easy to embed in a .svg with Spectrum.get_conditions()), but that would be asking for a lot already!

Implementation Idea

Graphviz produces light .svg files that can even be made interactive. Good example here (but should be horizontal ?).

We may require the "inspect" module to parse the code given by the user in the Config function ; or add another way to input the line-of-sight; maybe a class that would retain the relationships between the different spectra of the line-of-sight in a graph, be able to plot itself, and compute the resulting line-of-sight spectrum on demand (and recompute if some spectrum of the graph are updated with new entries).

@erwanp erwanp added the enhancement New feature or request label Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant