Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geographic extent #27

Open
evetion opened this issue Jul 12, 2024 · 3 comments
Open

Geographic extent #27

evetion opened this issue Jul 12, 2024 · 3 comments

Comments

@evetion
Copy link
Collaborator

evetion commented Jul 12, 2024

Something that we can apply the correct crstrait on from GeoInterface. We can discuss here how intersections on such an extent would look like.

@rafaqz
Copy link
Owner

rafaqz commented Jul 13, 2024

This object will need implementations of all the predicates.

We can set up special cyclic dimensions that move any values to -180 : 180 cycle in the constructor. Then bounds in high-low order are wrapping around.

So predicates will have to check the bounds order and have a branch for both.

X=Cycle{-180,180}(170, -150) would do it and be generic.

@evetion
Copy link
Collaborator Author

evetion commented Jul 13, 2024

That looks nice! However, can we also generically implement crstrait (i.e. dispatch) on it? Any Extent with a Cycle as one of its dims?

@rafaqz
Copy link
Owner

rafaqz commented Jul 13, 2024

Yeah we may still need a wrapper type, but this at least makes the predicates generic to any cyclic dimension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants